Holograph contest - sikorico's results

Omnichain protocol for deploying, minting, & bridging NFTs between blockchains.

General Information

Platform: Code4rena

Start Date: 18/10/2022

Pot Size: $75,000 USDC

Total HM: 27

Participants: 144

Period: 7 days

Judge: gzeon

Total Solo HM: 13

Id: 170

League: ETH

Holograph

Findings Distribution

Researcher Performance

Rank: 104/144

Findings: 2

Award: $0.00

QA:

grade-c

Gas:

grade-c

🌟 Selected for report: 0

🚀 Solo Findings: 0

External Links

Code4rena Contest Page Github Contest Repository Github Findings Repository Holograph

Findings Information

🌟 Selected for report: Rolezn

Also found by: 0x1f8b, 0x52, 0x5rings, 0xNazgul, 0xSmartContract, 0xZaharina, 0xhunter, 0xzh, 8olidity, Amithuddar, Aymen0909, B2, Bnke0x0, Chom, Deivitto, Diana, Diraco, Dravee, Franfran, JC, Jeiwan, Josiah, JrNet, Jujic, KingNFT, KoKo, Lambda, Margaret, Migue, Ocean_Sky, PaludoX0, Picodes, Rahoz, RaoulSchaffranek, RaymondFam, RedOneN, ReyAdmirado, Shinchan, Tagir2003, Trust, Waze, Yiko, __141345__, a12jmx, adriro, ajtra, arcoun, aysha, ballx, bin2chen, bobirichman, brgltd, bulej93, catchup, catwhiskeys, caventa, cccz, cdahlheimer, ch0bu, chaduke, chrisdior4, cloudjunky, cryptostellar5, cryptphi, csanuragjain, cylzxje, d3e4, delfin454000, djxploit, durianSausage, erictee, fatherOfBlocks, francoHacker, gianganhnguyen, gogo, hansfriese, i_got_hacked, ignacio, imare, karanctf, kv, leosathya, louhk, lukris02, lyncurion, m_Rassska, malinariy, martin, mcwildy, mics, minhtrng, nicobevi, oyc_109, pashov, peanuts, pedr02b2, peiw, rbserver, ret2basic, rotcivegaf, rvierdiiev, ryshaw, sakman, sakshamguruji, saneryee, securerodd, seyni, sikorico, svskaushik, teawaterwire, tnevler, w0Lfrum

Awards

0 USDC - $0.00

Labels

bug

QA (Quality Assurance)

sponsor confirmed

responded

grade-c

External Links

Link to GitHub issue

QA REPORT

[QA 00] Some tokens needs approve 0 before any approve above 0

Consider using increase/decrease approve notation instead approve to deal with that.

Proof of concept:

[QA 01] The following require statements are missing an error message

Proof of concept:

[QA 02] Missing MIT licence for the following contracts

Proof of concept:

[QA 03] Use the multiplication math operators before the divisions in the following locations

Proof of concept:

[QA 04] Not emitted event for state changes

Proof of concept:

#0 - alexanderattar
2022-11-09T21:58:13Z

The contracts are not MIT license

Findings Information

🌟 Selected for report: oyc_109

Also found by: 0x040, 0x1f8b, 0x5rings, 0xNazgul, 0xSmartContract, 0xZaharina, 0xsam, 0xzh, 2997ms, Amithuddar, Aymen0909, B2, Bnke0x0, Deivitto, Diana, Dinesh11G, Franfran, JC, JrNet, Jujic, KingNFT, KoKo, Mathieu, Metatron, Mukund, Olivierdem, PaludoX0, Pheonix, Picodes, RaymondFam, RedOneN, ReyAdmirado, Rolezn, Saintcode_, Satyam_Sharma, Shinchan, Tagir2003, Tomio, Waze, Yiko, __141345__, adriro, ajtra, aysha, ballx, beardofginger, bobirichman, brgltd, bulej93, catchup, catwhiskeys, cdahlheimer, ch0bu, chaduke, chrisdior4, cryptostellar5, cylzxje, d3e4, delfin454000, dharma09, djxploit, durianSausage, emrekocak, erictee, exolorkistis, fatherOfBlocks, gianganhnguyen, gogo, halden, hxzy, i_got_hacked, iepathos, karanctf, leosathya, lucacez, lukris02, lyncurion, m_Rassska, martin, mcwildy, mics, nicobevi, peanuts, peiw, rbserver, ret2basic, rotcivegaf, ryshaw, sakman, sakshamguruji, saneryee, sikorico, skyle, svskaushik, tnevler, vv7, w0Lfrum, zishansami

Awards

0 USDC - $0.00

Labels

bug

G (Gas Optimization)

sponsor confirmed

responded

grade-c

External Links

Link to GitHub issue

Holograph contest - sikorico's results

Omnichain protocol for deploying, minting, & bridging NFTs between blockchains.

General Information

Findings Distribution

Researcher Performance

External Links

Findings Information

Awards

Labels

External Links

QA REPORT

[QA 00] Some tokens needs approve 0 before any approve above 0

Proof of concept:

[QA 01] The following require statements are missing an error message

Proof of concept:

[QA 02] Missing MIT licence for the following contracts

Proof of concept:

[QA 03] Use the multiplication math operators before the divisions in the following locations

Proof of concept:

[QA 04] Not emitted event for state changes

Proof of concept:

#0 - alexanderattar
2022-11-09T21:58:13Z

Findings Information

Awards

Labels

External Links

GAS REPORT

[GAS 00] Use custom error instead string error for the following require statements

Proof of concept:

[GAS 01] Use `> 0` instead `!= 0` to check if an unsigned int is not 0

Proof of concept:

[GAS 02] Cache the array size for the following loops over array

Proof of concept:

Holograph contest - sikorico's results

Omnichain protocol for deploying, minting, & bridging NFTs between blockchains.

General Information

Findings Distribution

Researcher Performance

External Links

[Q-109] QA Report - $0.00

Findings Information

Awards

Labels

External Links

QA REPORT

[QA 00] Some tokens needs approve 0 before any approve above 0

Proof of concept:

[QA 01] The following require statements are missing an error message

Proof of concept:

[QA 02] Missing MIT licence for the following contracts

Proof of concept:

[QA 03] Use the multiplication math operators before the divisions in the following locations

Proof of concept:

[QA 04] Not emitted event for state changes

Proof of concept:

#0 - alexanderattar2022-11-09T21:58:13Z

[G-95] Gas Report - $0.00

Findings Information

Awards

Labels

External Links

GAS REPORT

[GAS 00] Use custom error instead string error for the following require statements

Proof of concept:

[GAS 01] Use > 0 instead != 0 to check if an unsigned int is not 0

Proof of concept:

[GAS 02] Cache the array size for the following loops over array

Proof of concept:

#0 - alexanderattar
2022-11-09T21:58:13Z

[GAS 01] Use `> 0` instead `!= 0` to check if an unsigned int is not 0