Holograph contest - kv's results

Omnichain protocol for deploying, minting, & bridging NFTs between blockchains.

General Information

Platform: Code4rena

Start Date: 18/10/2022

Pot Size: $75,000 USDC

Total HM: 27

Participants: 144

Period: 7 days

Judge: gzeon

Total Solo HM: 13

Id: 170

League: ETH

Holograph

Findings Distribution

Researcher Performance

Rank: 125/144

Findings: 1

Award: $0.00

QA:
grade-c

🌟 Selected for report: 0

🚀 Solo Findings: 0

Lines of code

https://github.com/code-423n4/2022-10-holograph/blob/main/src/enforcer/HolographERC721.sol#L307 https://github.com/code-423n4/2022-10-holograph/blob/main/src/enforcer/HolographERC721.sol#L415

Vulnerability details

_safeMint() should be used rather than _mint() wherever possible

_mint() is discouraged in favor of _safeMint() which ensures that the recipient is either an EOA or implements IERC721Receiver. Both open OpenZeppelin and solmate have versions of this function so that NFTs aren’t lost if they’re minted to contracts that cannot transfer them back out.

Instances

HolographERC721.sol:L307

src/enforcer/HolographERC721.sol:307: _mint(to, tokenId);

HolographERC721.sol:L415

src/enforcer/HolographERC721.sol:415: _mint(to, token);

Recommendations:

Use _safeMint() instead of _mint().

#0 - gzeoneth

2022-10-30T16:49:35Z

Duplicate of #462

#1 - gzeoneth

2022-11-21T07:24:48Z

As QA report

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter