Maia DAO - Ulysses - Zims's results

Lines of code

https://github.com/code-423n4/2023-09-maia/blob/f5ba4de628836b2a29f9b5fff59499690008c463/src/BranchPort.sol#L402-L411

Vulnerability details

Impact

updatePortStrategy() has no checks when called. Even an approved user can make a mistake and add an invalid _portStrategy or _token. addStrategyToken() has checks even though it has the same access control as updatePortStrategy(). When calling the function there is no revert if the caller makes a mistake. This might lead to excessive storage use of mistakes. And there is no warning if the caller makes a mistake

Proof of Concept

function updatePortStrategy(address _portStrategy, address _token, uint256 _dailyManagementLimit)
        external
        override
        requiresCoreRouter
    {
        strategyDailyLimitAmount[_portStrategy][_token] = _dailyManagementLimit;
        emit PortStrategyUpdated(_portStrategy, _token, _dailyManagementLimit);
    }

Accepts any input.

Tools Used

VScode, Audit Wizard

Recommended Mitigation Steps

Include some checks to ensure there is already a strategy for the token before updating it.

function updatePortStrategy(address _portStrategy, address _token, uint256 _dailyManagementLimit)
        external
        override
        requiresCoreRouter
    {
        if (!isStrategyToken[_token]) revert UnrecognizedStrategyToken();
        if (strategyDailyLimitAmount[_portStrategy][_token] == 0) revert StrategyTokenNotRegistered(); 

        strategyDailyLimitAmount[_portStrategy][_token] = _dailyManagementLimit;
        emit PortStrategyUpdated(_portStrategy, _token, _dailyManagementLimit);
    }

StrategyTokenNotRegistered() error needs to be defined in IBranchPort.sol

Assessed type

Invalid Validation