Maia DAO - Ulysses - castle_chain's results

Harnessing the power of Arbitrum, Ulysses Omnichain specializes in Virtualized Liquidity Management.

General Information

Platform: Code4rena

Start Date: 22/09/2023

Pot Size: $100,000 USDC

Total HM: 15

Participants: 175

Period: 14 days

Judge: alcueca

Total Solo HM: 4

Id: 287

League: ETH

Maia DAO

Findings Distribution

Researcher Performance

Rank: 148/175

Findings: 1

Award: $11.47

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

missed events should be emitted

the contract should emit events with the nonce in the bridge functions in the Branch bridge agent contracts https://github.com/code-423n4/2023-09-maia/blob/f5ba4de628836b2a29f9b5fff59499690008c463/src/BranchBridgeAgent.sol#L209-L228

function callOutAndBridge( address payable _refundee, bytes calldata _params, DepositInput memory _dParams, GasParams calldata _gParams ) external payable override lock { //Cache Deposit Nonce uint32 _depositNonce = depositNonce; //Encode Data for cross-chain call. bytes memory payload = abi.encodePacked( bytes1(0x02), _depositNonce, _dParams.hToken, _dParams.token, _dParams.amount, _dParams.deposit, _params ); //Create Deposit and Send Cross-Chain request _createDeposit(_depositNonce, _refundee, _dParams.hToken, _dParams.token, _dParams.amount, _dParams.deposit); //Perform Call _performCall(_refundee, payload, _gParams); }

should make sure that the msg.value is greater than or equal the gas parameters

when the user specify gas parameters the protocol should make sure that the msg.value is greater than or equal the gas parameters https://github.com/code-423n4/2023-09-maia/blob/f5ba4de628836b2a29f9b5fff59499690008c463/src/BranchBridgeAgent.sol#L209-L228

https://github.com/code-423n4/2023-09-maia/blob/f5ba4de628836b2a29f9b5fff59499690008c463/src/BranchBridgeAgent.sol#L195-L200

#0 - c4-pre-sort

2023-10-15T13:16:20Z

0xA5DF marked the issue as sufficient quality report

#1 - c4-judge

2023-10-21T12:54:49Z

alcueca marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter