Maia DAO - Ulysses - te_aut's results

Harnessing the power of Arbitrum, Ulysses Omnichain specializes in Virtualized Liquidity Management.

General Information

Platform: Code4rena

Start Date: 22/09/2023

Pot Size: $100,000 USDC

Total HM: 15

Participants: 175

Period: 14 days

Judge: alcueca

Total Solo HM: 4

Id: 287

League: ETH

Maia DAO

Findings Distribution

Researcher Performance

Rank: 152/175

Findings: 1

Award: $11.47

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

  1. SPELLING ERROR: SLoC - #19

CONTRACT NAME: ArbitrumCoreBranchRouter.sol Contract link: https://github.com/code-423n4/2023-09-maia/blob/main/src/ArbitrumCoreBranchRouter.sol LINE OF CODE: @dev The function addGlobalToken is is not available since it's used Recommendation: remove one of the two ‘is’ from the comment on SLoC #19

TOOLS USED: Manual review

POC: The ArbitrumCoreBranchRouter.sol contract has a comment of the contract ArbitrumCoreBranchRouter on SLoC #19. The comment’s intention is used to explain what the contract does, however, the word repetition error can be confusing. If it’s an error, remove one of the two “is” otherwise, update the comment.

  1. SPELLING ERROR: SLoC - #74 AND #80

CONTRACT NAME: ArbitrumBranchBridgeAgent.sol Contract link: https://github.com/code-423n4/2023-09-maia/blob/main/src/ArbitrumBranchBridgeAgent.sol LINE OF CODE: SLoC #74 * @notice Function to withdraw a single asset to the local Port. SLoC #80 IArbPort(localPortAddress).withdrawFromPort(msg.sender, msg.sender, localAddress, amount);

Recommendation: The ‘withdraw a single asset to’ can be changed to ‘withdraw a single asset from’ to match the function ‘withrdrawFromPort’.

TOOLS USED: Manual review

POC: The ArbitrumBranchBridgeAgent.sol contract has a comment of the function withdrawFromPort on SLoC #74. The comment’s intention is used to explain what the function withdrawFromPort does, however, the sentencing of the comment ‘withdraw a single asset to’ can be confusing. If it’s an error, change the word ‘to’ to ‘from’ to make sense of the function withdrawFromPort on SLoc #80 otherwise, update the comment.

#0 - c4-pre-sort

2023-10-15T12:06:33Z

0xA5DF marked the issue as low quality report

#1 - 0xA5DF

2023-10-15T12:06:35Z

Only 2 NCs

#2 - c4-judge

2023-10-21T05:10:13Z

alcueca marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter