Platform: Code4rena
Start Date: 22/09/2023
Pot Size: $100,000 USDC
Total HM: 15
Participants: 175
Period: 14 days
Judge: alcueca
Total Solo HM: 4
Id: 287
League: ETH
Rank: 152/175
Findings: 1
Award: $11.47
đ Selected for report: 0
đ Solo Findings: 0
đ Selected for report: MrPotatoMagic
Also found by: 0xAadi, 0xDING99YA, 0xDemon, 0xRstStn, 0xSmartContract, 0xStriker, 0xWaitress, 0xbrett8571, 0xfuje, 0xsagetony, 0xsurena, 33BYTEZZZ, 3docSec, 7ashraf, ABA, ABAIKUNANBAEV, Aamir, Audinarey, Bauchibred, Black_Box_DD, Daniel526, DanielArmstrong, DanielTan_MetaTrust, Dinesh11G, Eurovickk, Franklin, Inspecktor, John, Jorgect, Joshuajee, K42, Kek, Koolex, LokiThe5th, MIQUINHO, Myd, NoTechBG, QiuhaoLi, SanketKogekar, Sathish9098, Sentry, Soul22, SovaSlava, Stormreckson, Tendency, Topmark, Udsen, V1235816, Viktor_Cortess, Viraz, Yanchuan, ZdravkoHr, Zims, albahaca, albertwh1te, alexweb3, alexxander, ast3ros, audityourcontracts, bareli, bin2chen, bronze_pickaxe, c0pp3rscr3w3r, cartlex_, castle_chain, chaduke, debo, ether_sky, gumgumzum, imare, its_basu, jaraxxus, jasonxiale, josephdara, kodyvim, ladboy233, lanrebayode77, lsaudit, mert_eren, minhtrng, n1punp, nadin, niroh, nmirchev8, orion, peakbolt, perseverancesuccess, pfapostol, ptsanev, rvierdiiev, saneryee, shaflow2, te_aut, terrancrypt, twcctop, unsafesol, ustas, versiyonbir, windhustler, yongskiws, zhaojie, ziyou-
11.4657 USDC - $11.47
CONTRACT NAME: ArbitrumCoreBranchRouter.sol
Contract link: https://github.com/code-423n4/2023-09-maia/blob/main/src/ArbitrumCoreBranchRouter.sol
LINE OF CODE: @dev The function addGlobalToken
is is not available since it's used
Recommendation: remove one of the two âisâ from the comment on SLoC #19
TOOLS USED: Manual review
POC: The ArbitrumCoreBranchRouter.sol contract has a comment of the contract ArbitrumCoreBranchRouter on SLoC #19. The commentâs intention is used to explain what the contract does, however, the word repetition error can be confusing. If itâs an error, remove one of the two âisâ otherwise, update the comment.
CONTRACT NAME: ArbitrumBranchBridgeAgent.sol Contract link: https://github.com/code-423n4/2023-09-maia/blob/main/src/ArbitrumBranchBridgeAgent.sol LINE OF CODE: SLoC #74 * @notice Function to withdraw a single asset to the local Port. SLoC #80 IArbPort(localPortAddress).withdrawFromPort(msg.sender, msg.sender, localAddress, amount);
Recommendation: The âwithdraw a single asset toâ can be changed to âwithdraw a single asset fromâ to match the function âwithrdrawFromPortâ.
TOOLS USED: Manual review
POC: The ArbitrumBranchBridgeAgent.sol contract has a comment of the function withdrawFromPort on SLoC #74. The commentâs intention is used to explain what the function withdrawFromPort does, however, the sentencing of the comment âwithdraw a single asset toâ can be confusing. If itâs an error, change the word âtoâ to âfromâ to make sense of the function withdrawFromPort on SLoc #80 otherwise, update the comment.
#0 - c4-pre-sort
2023-10-15T12:06:33Z
0xA5DF marked the issue as low quality report
#1 - 0xA5DF
2023-10-15T12:06:35Z
Only 2 NCs
#2 - c4-judge
2023-10-21T05:10:13Z
alcueca marked the issue as grade-b