The Graph L2 bridge contest - carlitox477's results

Multiple access to state variables can be avoided

• Governed#transferOwnership can be changed to emit NewPendingOwnership(oldPendingGovernor, _newGovernor);
• Governed#acceptOwnership can be changed to emit NewOwnership(oldGovernor, oldPendingGovernor);. In this particular case, move this line to the start of the function, and replace every instance of pendingGovernor for oldPendingGovernor, except from this line. Also replace this line for emit NewPendingOwnership(oldPendingGovernor, address(0));
• Pausable#_setPartialPaused can be replaced for emit PartialPauseChanged(_toPause);; and this line can be replaced for if (_toPause) {
• Pausable#_setPaused can be replaced for emit PauseChanged(_toPause);; and this line can be replaced for if (_toPause) {
• Pausable#_setPauseGuardian can be replaced for emit NewPauseGuardian(oldPauseGuardian, newPauseGuardian);
• L2GraphTokenGateway#outboundTransfer access twice to state variable l1GRT
• L2GraphTokenGateway#finalizeInboundTransfer access twice to state variable escrow

Splitting require() statements that use && saves gas

See this issue which describes the fact that there is a larger deployment gas cost, but with enough runtime calls, the change ends up being cheaper by 3 gas.

Instances found:

• Governed#acceptOwnership

Internal/private functions called once can be avoided to save gas

Not inlining costs 20 to 40 gas because of two extra JUMP instructions and additional stack operations needed for function calls.

• Managed#notPartialPaused is called just once by modifier notPartialPaused()
• Managed#_notPaused is called just once by modifier _notPaused()
• Managed#_onlyController() is called just once by modifier onlyController()
• GraphTokenUpgradeable#_getChainID is called once in _initialize function

Inline hashing can be put in immutable variables to avoid calculation

• Managed#curation can avoid calculate keccak256("Curation") by putting its value in an immutable variable
• Managed#epochManager can avoid calculate keccak256("EpochManager") by putting its value in an immutable variable
• Managed#rewardsManager can avoid calculate keccak256("RewardsManager") by putting its value in an immutable variable
• Managed#staking can avoid calculate keccak256("Staking") by putting its value in an immutable variable
• Managed#graphToken can avoid calculate keccak256("GraphToken") by putting its value in an immutable variable
• Managed#graphTokenGateway can avoid calculate keccak256("GraphTokenGateway") by putting its value in an immutable variable