Platform: Code4rena
Start Date: 03/05/2022
Pot Size: $50,000 USDC
Total HM: 4
Participants: 46
Period: 5 days
Judge: gzeon
Total Solo HM: 2
Id: 117
League: ETH
Rank: 45/46
Findings: 1
Award: $52.48
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: BowTiedWardens
Also found by: 0v3rf10w, 0x1f8b, 0x4non, 0xDjango, 0xNazgul, 0xkatana, Cityscape, Fitraldys, Funen, GimelSec, IllIllI, MaratCerby, Picodes, TerrierLover, Tomio, delfin454000, ellahi, fatherOfBlocks, hansfriese, ilan, joestakey, oyc_109, rfa, robee, samruna, simon135, slywaters, throttle
52.4836 USDC - $52.48
use != 0 instead of > 0 Comptroller.sol#L302 Comptroller.sol#L353 Comptroller.sol#L631 Comptroller.sol#L1097 Comptroller.sol#L1100 Comptroller.sol#L1106 Comptroller.sol#L1120 Comptroller.sol#L1123 Comptroller.sol#L1129 Comptroller.sol#L1145 Comptroller.sol#L1169 Comptroller.sol#L1187 Comptroller.sol#L1255 Oracles\UniswapV2PriceOracle.sol#L67 Oracles\UniswapV2PriceOracle.sol#L91 Oracles\UniswapV2PriceOracle.sol#L115
use ++i instead of i++, i+=1 Comptroller.sol#L119 Comptroller.sol#L591 Comptroller.sol#L928 Comptroller.sol#L949 (There are so many cases in other sources)
Check require() before calculation if possible You can check this require() before #L89 CNft.sol#L93
no need to initialize variables with default values CNft.sol#L49 CNft.sol#L97 CNft.sol#L119 Comptroller.sol#L119 Comptroller.sol#L591 Comptroller.sol#L928 Comptroller.sol#L949 Oracles\CNftPriceOracle.sol#L66 Oracles\UniswapV2PriceOracle.sol#L42