bunker.finance contest - 0xDjango's results

Issue #1 (Low) - Floating pragma

All contracts contain a floating pragma. It is recommended to deploy all contracts with a single, specific compiler version to reduce the risk of compiler-specific bugs and contracts deployed with different versions. In the case of the forked contacts, I recommend deploying with the exact version that the current live versions were deployed with.

E.g. https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/CErc20.sol#L1

Issue #2 (Low) - No ownership transfer pattern

It is recommended to implement an acceptOwnershipTransfer() function to reduce the risk of transferring ownership to the wrong account or zero address. The pattern would include a transferOwnership() function to set the pending new owner, and the acceptOwnershipTransfer() function would have to be called by the pending owner for the transfer to take effect.

https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/Comptroller.sol#L731-L734

Issue #3 (Low) - lack of address(0) validation

When setting the address of the NFT oracle, the new address should be validated that it is not address(0).

https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/Comptroller.sol#L771 https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/Comptroller.sol#L751

Issue #4 (Non-critical) - Coding practice: Interfaces should start with "I"

https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/EIP20Interface.sol#L7

Issue #5 (Non-critical) - Coding practice: Only internal functions should start with "_"

https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/Comptroller.sol#L731-L925

Optimization #1 - For loop optimization

This for loop can be optimized by incrementing i within unchecked{}. The new pattern would be:

      for (uint i = 0; i < length;) {
          seizeTokens -= seizeAmounts[i];
          unchecked {
              ++i;
          }
      }

https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/CToken.sol#L1090-L1092