bunker.finance contest - ilan's results

NC01 some functions declarations exceed recommended maximum line length

From the solidity style guide:

Keeping lines under the PEP 8 recommendation to a maximum of 79 (or 99) characters helps readers easily parse the code.

Example instance

Recommendation make the function declarations over multiple lines

function name(
        type param1,
        type param2,
        type param3
    ) visibilty {
        body
    }

NC02 Many functions are missing documentation

Many functions and complex logic are missing informative documentation and comments.

For example CNft.safeBatchTransferFrom

G01 No need to explicitly initialize variables with default values

If a variable is not initialized it is automatically set to the default value (0 for uint, false for bool, address(0) for address...). Explicitly initializing it with its default value is an anti-pattern and wastes gas.

Example:

uint256 totalAmount = 0; -> uint256 totalAmount;

CNft.sol#L49-L49