Platform: Code4rena
Start Date: 14/06/2022
Pot Size: $100,000 USDC
Total HM: 26
Participants: 59
Period: 7 days
Judge: GalloDaSballo
Total Solo HM: 9
Id: 133
League: ETH
Rank: 49/59
Findings: 1
Award: $183.51
π Selected for report: 0
π Solo Findings: 0
π Selected for report: joestakey
Also found by: 0x1f8b, 0x29A, 0x52, 0xDjango, 0xNazgul, 0xf15ers, 0xmint, Bronicle, Dravee, Funen, JMukesh, Limbooo, MadWookie, Picodes, Ruhum, TerrierLover, TomJ, Tutturu, WatchPug, Waze, _Adam, asutorufos, c3phas, catchup, cccz, codexploder, cryptphi, csanuragjain, defsec, fatherOfBlocks, gzeon, hake, hansfriese, hyh, ignacio, k, nxrblsrpr, oyc_109, robee, sach1r0, saian, simon135, technicallyty, zzzitron
72.3997 USDC - $72.40
687.9945 CANTO - $111.11
https://github.com/Plex-Engineer/zeroswap/blob/03507a80322112f4f3c723fc68bed0f138702836/contracts/mocks/WETH9Mock.sol#L26 https://github.com/Plex-Engineer/zeroswap/blob/0fa049912bc14c27ba60efbada23fc1cc18b04e4/test/SushiToken.test.ts#L46 https://github.com/Plex-Engineer/zeroswap/blob/0fa049912bc14c27ba60efbada23fc1cc18b04e4/test/SushiMaker.test.ts#L52 https://github.com/Plex-Engineer/zeroswap/blob/0fa049912bc14c27ba60efbada23fc1cc18b04e4/contracts/SushiBar.sol#L49
CALL() SHOULD BE USED INSTEAD OF TRANSFER() ON AN ADDRESS PAYABLE
The use of the deprecated transfer() function for an address will inevitably make the transaction fail when:
-The claimer smart contract does implement a payable fallback which uses more than 2300 gas unit. -The claimer smart contract implements a payable fallback function that needs less than 2300 gas units but is called through proxy, raising the callβs gas usage above 2300 and using higher than 2300 gas might be mandatory for some multisig wallets. -The claimer smart contract does not implement a payable function.
#0 - nivasan1
2022-06-23T04:13:57Z
duplicate of #14