Canto contest - MadWookie's results

Low Risk

Missing check for address(0x0) when assigning values to address state variables

Especially import when assigning to admin as it could brick the contract if set to address(0x0)

1. File: TreasuryDelegator.sol#L21

	admin = admin_;

QA

Use of transfer

It is not recommended to use transfer as it will make contracts potentially unusable if the transfer gas cost is ever increased.

It is recommended to use call instead like so

(bool success, ) = payable(msg.sender).call.value(wad)("");

1. File: WETH.sol#L31

payable(msg.sender).transfer(wad);

Missing URL in comment

1. File: GovernorBravoInterfaces.sol#L31

    IProposal unigov; //Proposal Store object defined as primitive contract in Canto-Testnet <URL HERE>  

Gas report

Initializing variables to default values wastes gas

The defalut value for uint is 0 and the default value for bool is false

1. File:GovernorBravoDelegate.sol#L57

    newProposal.eta = 0;

2. File:GovernorBravoDelegate.sol#L62

    newProposal.canceled = false;

Functions add256() and sub256() are not needed as solidity version 0.8.10 has built-in overflow/underflow checking.

These functions are wasting gas.

1. File:GovernorBravoDelegate.sol#L180-184

    function add256(uint256 a, uint256 b) internal pure returns (uint) {
        uint c = a + b;
        require(c >= a, "addition overflow");
        return c;
    }

2. File:GovernorBravoDelegate.sol#L186-189

    function sub256(uint256 a, uint256 b) internal pure returns (uint) {
        require(b <= a, "subtraction underflow");
        return a - b;
    }