Platform: Code4rena
Start Date: 14/06/2022
Pot Size: $100,000 USDC
Total HM: 26
Participants: 59
Period: 7 days
Judge: GalloDaSballo
Total Solo HM: 9
Id: 133
League: ETH
Rank: 26/59
Findings: 4
Award: $782.50
🌟 Selected for report: 0
🚀 Solo Findings: 0
1532.982 CANTO - $247.58
247.5766 USDC - $247.58
All the relevant fields for a proposal is set in queue () but executed is marked as true, even before the proposal is even queued. When it comes time to execute a proposal, this will be impossible since state () will always return ProposalState.Executed.
The condition below will never return true
newProposal.executed should be the default value (false) as it is set after the condition is checked in state() :
#0 - nivasan1
2022-06-24T03:21:08Z
duplicate of #39
🌟 Selected for report: joestakey
Also found by: 0x1f8b, 0x29A, 0x52, 0xDjango, 0xNazgul, 0xf15ers, 0xmint, Bronicle, Dravee, Funen, JMukesh, Limbooo, MadWookie, Picodes, Ruhum, TerrierLover, TomJ, Tutturu, WatchPug, Waze, _Adam, asutorufos, c3phas, catchup, cccz, codexploder, cryptphi, csanuragjain, defsec, fatherOfBlocks, gzeon, hake, hansfriese, hyh, ignacio, k, nxrblsrpr, oyc_109, robee, sach1r0, saian, simon135, technicallyty, zzzitron
72.4555 USDC - $72.46
687.9945 CANTO - $111.11
Modify comments
‘@notice Returns the WETH address
@return the WETH address’
NatSpec @param missing
@param treasury_:
@param borrower
Grammatical Errors
‘paid’
‘underlying’
‘it's’
Use assignment operator for better readability
Use - = :
+=:
Variables are already default type
isPaused is already implicitly false,no need to set it in the constructor since setPause() exists :
Already zero, no need to initialise.
#0 - GalloDaSballo
2022-08-01T23:16:11Z
Valid NC
NC
NC
Disagree as convention is to use those only in assembly
##Â Variables are already default type
Valid Ref
Overall could have been formatted better, and I think there are tons more things the warden could have found
#1 - GalloDaSballo
2022-08-01T23:16:18Z
1 R 3 NC
🌟 Selected for report: _Adam
Also found by: 0v3rf10w, 0x1f8b, 0x29A, 0xKitsune, 0xNazgul, 0xf15ers, 0xkatana, 0xmint, Chom, Dravee, Fitraldys, Funen, JC, Limbooo, MadWookie, Picodes, Ruhum, TerrierLover, TomJ, Tomio, Waze, ak1, c3phas, catchup, defsec, fatherOfBlocks, gzeon, hake, hansfriese, joestakey, k, oyc_109, rfa, robee, sach1r0, saian, simon135, ynnad
39.6748 USDC - $39.67
396.9199 CANTO - $64.10
#0 - GalloDaSballo
2022-08-04T00:12:23Z
40 gas saved