Nouns DAO contest - rajatbeladiya's results

A DAO-driven NFT project on Ethereum.

General Information

Platform: Code4rena

Start Date: 22/08/2022

Pot Size: $50,000 USDC

Total HM: 4

Participants: 160

Period: 5 days

Judge: gzeon

Total Solo HM: 2

Id: 155

League: ETH

Nouns DAO

Findings Distribution

Researcher Performance

Rank: 104/160

Findings: 1

Award: $35.44

🌟 Selected for report: 0

🚀 Solo Findings: 0

1). Unlocked pragma versions

instances: 1, 2, 3, 4

t's good practice to use specific solidity version to know compiler bug fixes and optimisations were enabled at the time of compiling the contract.

2). Add Zero address validation

NounsDAOLogicV1.sol#L116

3). use 0.8.6 for ERC721Enumerable as it uses 0.8.0

ERC721Enumerable.sol

4). ecrecover directly used to verify the signture

NounsDAOLogicV1.sol#L484

would recommend to using the ECDSA from openzeppelin as it does more validations when verifying the signature

5). emit admin address on withdraw

NounsDAOLogicV2.sol#L791

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter