Nouns DAO contest - tnevler's results

A DAO-driven NFT project on Ethereum.

General Information

Platform: Code4rena

Start Date: 22/08/2022

Pot Size: $50,000 USDC

Total HM: 4

Participants: 160

Period: 5 days

Judge: gzeon

Total Solo HM: 2

Id: 155

League: ETH

Nouns DAO

Findings Distribution

Researcher Performance

Rank: 91/160

Findings: 2

Award: $52.10

🌟 Selected for report: 0

πŸš€ Solo Findings: 0

Report

Non-Critical Issues

[N-01]: NatSpec Is Missing

Description: NatSpec if missing for the following function:

Recommendation: Implement NatSpec for all functions.

[N-02]: Wrong order of functions

Context: L1030

Description: According official solidity documentation receive function must be placed after the constructor.

Recommendation: Remove the receive function from L1030 and add it to L167.

[N-03]: Comstant instead of unknown divisor

Context: L1007

Description: You should use constant variables to make the code easier to understand and maintain.

Recommendation: Define constant variables for the divisor.

Report

Gas Optimizations

[G-01]: ++i costs less gas than i++

Description:

Recommendation: Change i++ to ++i.

[G-02]: Use new variable instead of reading array length in every loop of a for-loop

Description: If you read the length of the array at each iteration of the loop, this consumes a lot of gas.

Recommendation: Store the array’s length in a variable before the for-loop, and use this new variable in the loop.

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax Β© 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter