Badger Citadel contest - 0v3rf10w's results

Bringing BTC to DeFi

General Information

Platform: Code4rena

Start Date: 14/04/2022

Pot Size: $75,000 USDC

Total HM: 8

Participants: 72

Period: 7 days

Judge: Jack the Pug

Total Solo HM: 2

Id: 110

League: ETH

BadgerDAO

Findings Distribution

Researcher Performance

Rank: 50/72

Findings: 2

Award: $143.54

🌟 Selected for report: 0

🚀 Solo Findings: 0

QA1: Front-runnable Initializers

no acess control mdifiers are used in initialiser that can be lead to front running by bots/bad actors By front-running the contract deployers to initialize the contract, the incorrect parameters may be supplied, leaving the contract needing to be redeployed and can delay/disrupt contract deployment.

Funding.sol L#104

Gas1: Prefer calldata instead of memory for external functions with read only data

StakedCitadel.sol L#341 L#366 L#780 L#791

  • use calldata instead of memory for proof because it's external and read only, similar to KnightingRound.sol L#165

Gas2: Compiled in PullPrequest PR-34 to Citadel-DAO/citadel-contracts repo

Minor Optimisations including -

  • != for unsigned integers instead of >
  • prefer prefix instead of suffic and even better if unchecked for loops
AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter