Badger Citadel contest - Tomio's results

1. Using unchecked and prefix increment can save gas

Proof of Concept: https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/CitadelMinter.sol#L152

Recommended Mitigation Steps: change to prefix increment and unchecked

========================================================================

2. Using += to increase value on var

Proof of Concept: https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/CitadelMinter.sol#L279 https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/KnightingRound.sol#L196-L199

Recommended Mitigation Steps: Change to:

	_newTotalWeight += _weight;

========================================================================

3. Using != instead of > is more gas efficient

Proof of Concept: https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/CitadelMinter.sol#L343 https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/Funding.sol#L170 https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/Funding.sol#L452

Recommended Mitigation Steps: Change to:

	require(length != 0, "CitadelMinter: no funding pools");

========================================================================

4. unnecessary value set. the default value of uint is zero.

Proof of Concept: https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/CitadelMinter.sol#L152 https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/CitadelMinter.sol#L180-L182 https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/SupplySchedule.sol#L192

Recommended Mitigation Steps: remove 0

========================================================================

5. using delete statement can save gas

Proof of Concept: https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/CitadelMinter.sol#L366 https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/StakedCitadel.sol#L416

Recommended Mitigation Steps: Change to:

	delete fundingPoolWeights[_pool];

========================================================================

6. Using unchecked can save gas

Proof of Concept: https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/Funding.sol#L236 https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/KnightingRound.sol#L250

Recommended Mitigation Steps:

Unchecked{
limitLeft_ = assetCap - assetCumulativeFunded;
}

========================================================================

7. Using > is cheaper than >=

Proof of Concept: https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/Funding.sol#L270-L271 https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/Funding.sol#L361

Recommended Mitigation Steps: 1 second difference can be ignored to validate Change from: >= or <= to: > or <

========================================================================

8. Using calldata to store struct data type can save gas

Proof of Concept: https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/Funding.sol#L244

Recommended Mitigation Steps: Change memory to calldata

========================================================================

9. Gas improvement on returning governancePerformanceFee and strategistPerformanceFee value

Proof of Concept: https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/StakedCitadel.sol#L859

Recommended Mitigation Steps: declare governancePerformanceFee, strategistPerformanceFee in function returns and delete #L874 can save gas

function _calculatePerformanceFee(uint256 _amount)
        internal
        view
        returns (uint256 governancePerformanceFee, uint256 strategistPerformanceFee) //@audit-info return here
    {
        uint256 governancePerformanceFee = _calculateFee(
            _amount,
            performanceFeeGovernance
        );

        uint256 strategistPerformanceFee = _calculateFee(
            _amount,
            performanceFeeStrategist
        );
    }

========================================================================

10. unnecessary citadelAmountWithoutDiscount MSTORE

Proof of Concept: https://github.com/code-423n4/2022-04-badger-citadel/blob/main/src/Funding.sol#L207

Recommended Mitigation Steps: citadelAmountWithoutDiscount only called once. just calculated directly to citadelAmount_ #L211

 if (funding.discount > 0) {
            citadelAmount_ =
                ((_assetAmountIn * citadelPriceInAsset)* MAX_BPS) /
                (MAX_BPS - funding.discount);
        }

========================================================================