Badger Citadel contest - csanuragjain's results

Funding.sol#L414: updateCitadelPriceInAsset function

If updateCitadelPriceInAsset resulted in invalid price,citadelPriceFlag is set to true. After sometime if same function is called and price come correctly then citadelPriceFlag should be set to false so that deposit are not impacted but this is not done.

Recommendation : Put citadelPriceFlag to false in case if price is in valid range

Funding.sol#L356: setDiscountLimits function

Add check _minDiscount<_maxDiscount (otherwise minDiscount could exceed maxDiscount)

SupplySchedule.sol#L150: setEpochRate function

check _rate!=0 (since 0 is an invalid input)

SupplySchedule.sol#L178: getMintableDebug

The condition require(lastMintTimestamp > globalStartTimestamp,"SupplySchedule: attempting to mint before start block"); does not cover valid case where lastMintTimestamp=globalStartTimestamp

Recommendation: Change to require(lastMintTimestamp >= globalStartTimestamp,"SupplySchedule: attempting to mint before start block");

StakedCitadelVester.sol#L108: claimableBalance function

If user revests then unlockEnd date will change. This will become a problem if user has already claimed major portion because after user revests now locked<claimed which means function will always fail

Recommendation: add check

((locked * (block.timestamp - vesting[recipient].unlockBegin)) /(vesting[recipient].unlockEnd - vesting[recipient].unlockBegin))  >= claimed

StakedCitadelVester.sol#L163: setVestingDuration function

Add a check for _duration!=0 (as 0 vesting duration is invalid)

CitadelMinter.sol#L250: setFundingPoolWeight function Directly assign totalFundingPoolWeight=totalFundingPoolWeight-fundingPoolWeights[_pool]+_weight instead of using temp variable

SupplySchedule.sol#L84: getMintable function

check if endingEpoch==0 return 0 which will save some gas