Platform: Code4rena
Start Date: 14/04/2022
Pot Size: $75,000 USDC
Total HM: 8
Participants: 72
Period: 7 days
Judge: Jack the Pug
Total Solo HM: 2
Id: 110
League: ETH
Rank: 69/72
Findings: 1
Award: $52.17
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: Dravee
Also found by: 0v3rf10w, 0x1f8b, 0xAsm0d3us, 0xBug, 0xDjango, 0xNazgul, 0xkatana, CertoraInc, Cityscape, Funen, Hawkeye, IllIllI, MaratCerby, SolidityScan, TerrierLover, TomFrenchBlockchain, Tomio, TrungOre, bae11, berndartmueller, csanuragjain, defsec, delfin454000, ellahi, fatherOfBlocks, gs8nrv, gzeon, horsefacts, ilan, jah, joestakey, joshie, kebabsec, kenta, nahnah, oyc_109, rayn, rfa, robee, saian, securerodd, simon135, slywaters, sorrynotsorry, tchkvsky, teryanarmen, z3s
52.1707 USDC - $52.17
Citadelminer.sol:
fundingPoolWeights[_pool] = 0;
Should be Uninitialized should be used and make it less gas with same result
Line 370 string require more then 32 bytes takes up more gas
Funding.sol
minCitadelPriceInAsset Variable never used so just leave it uninitialized
Line 148 require string more then 32 bytes make shorter to save gas.
Line 170
Require statement require says not zero so to save gas != 0 or change there require statement has to be
Greater then 0
Line 424 same thing as above
KnightingRound.sol
Function initialize
Gas save with the non zero by != To save gas also the string have to be less then 32 bytes or cost more gas
Lines:124,128,313
Stakedcitadel.sol
uint256 constant ONE_ETH = 1e18; should be 10** 18 tp save gas
StakedcitadelVestor.sol
Line:138 require says not vest zero save gas !=
Supplyshed.sol
Line:96 to big string
Line 143 string to big