PoolTogether Aave v3 contest - 0x4non's results

A protocol for no loss prize savings on Ethereum.

General Information

Platform: Code4rena

Start Date: 29/04/2022

Pot Size: $22,000 USDC

Total HM: 6

Participants: 40

Period: 3 days

Judge: Justin Goro

Total Solo HM: 2

Id: 114

League: ETH

PoolTogether

Findings Distribution

Researcher Performance

Rank: 26/40

Findings: 1

Award: $65.54

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

65.5393 USDC - $65.54

Labels

bug
G (Gas Optimization)

External Links

Consider removing safeMath library.

Source: https://github.com/OpenZeppelin/openzeppelin-contracts/commit/24a0bc23cfe3fbc76f8f2510b78af1e948ae6651#diff-f4b1737177aad965d94530b54ac4001a2e1f5fe6e4e34bafe023310cea599eca

Remove; https://github.com/pooltogether/aave-v3-yield-source/blob/e63d1b0e396a5bce89f093630c282ca1c6627e44/contracts/AaveV3YieldSource.sol#L26

Change; https://github.com/pooltogether/aave-v3-yield-source/blob/e63d1b0e396a5bce89f093630c282ca1c6627e44/contracts/AaveV3YieldSource.sol#L361

return _supply == 0 ? _tokens : _tokens.mul(_supply).div(aToken.balanceOf(address(this)));

For:

return _supply == 0 ? _tokens : (_tokens *_supply) / aToken.balanceOf(address(this));

Change: https://github.com/pooltogether/aave-v3-yield-source/blob/e63d1b0e396a5bce89f093630c282ca1c6627e44/contracts/AaveV3YieldSource.sol#L373

return _supply == 0 ? _shares : _shares.mul(aToken.balanceOf(address(this))).div(_supply);

For:

return _supply == 0 ? _shares : (_shares * aToken.balanceOf(address(this))) / _supply;

#0 - PierrickGT

2022-05-02T22:41:52Z

#1 - PierrickGT

2022-05-02T22:42:28Z

Detailed report by the warden, should get extra points.

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter