PoolTogether Aave v3 contest - horsefacts's results

Unnecessary constructor call

The ReentrancyGuard base contract takes no constructor arguments and can be omitted as a modifier for constructor:

constructor(
    IAToken _aToken,
    IRewardsController _rewardsController,
    IPoolAddressesProviderRegistry _poolAddressesProviderRegistry,
    string memory _name,
    string memory _symbol,
    uint8 decimals_,
    address _owner
  ) Ownable(_owner) ERC20(_name, _symbol) ReentrancyGuard() { ... }

Recommendation:

constructor(
    IAToken _aToken,
    IRewardsController _rewardsController,
    IPoolAddressesProviderRegistry _poolAddressesProviderRegistry,
    string memory _name,
    string memory _symbol,
    uint8 decimals_,
    address _owner
  ) Ownable(_owner) ERC20(_name, _symbol) { ... }

balanceOfToken can be declared as a view

The balanceOfToken function is read-only and can be declared as a view.

AaveV3YieldSource.sol#L212:

 function balanceOfToken(address _user) external override returns (uint256) {
    return _sharesToToken(balanceOf(_user));
  }

Recommendation:

 function balanceOfToken(address _user) external view override returns (uint256) {
    return _sharesToToken(balanceOf(_user));
  }

Note that this also declared incorrectly in the IYieldSource interface.

Unnecessary usage of SafeMath library

Solidity 0.8.0 introduced checked arithmetic by default, so the SafeMath library may safely be omitted.

Typo in natspec comment

inhereted should read inherited in the natspec comment on line 38.