Platform: Code4rena
Start Date: 29/04/2022
Pot Size: $22,000 USDC
Total HM: 6
Participants: 40
Period: 3 days
Judge: Justin Goro
Total Solo HM: 2
Id: 114
League: ETH
Rank: 34/40
Findings: 1
Award: $28.35
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: IllIllI
Also found by: 0v3rf10w, 0x1f8b, 0x4non, 0xDjango, 0xf15ers, 0xkatana, 242, Dravee, GimelSec, MaratCerby, Tadashi, TrungOre, WatchPug, defsec, fatherOfBlocks, gzeon, hake, horsefacts, joestakey, miguelmtzinf, pauliax, pedroais, peritoflores, rotcivegaf, simon135, slywaters, tabish, throttle, z3s
28.3489 USDC - $28.35
redeemToken and supplyTokenTo)Removing using SafeMath for uint256; and making adjustments accordingly to the contract's arithmetic as:
L262: uint256 _balanceDiff = _afterBalance - _beforeBalance;
L361: return _supply == 0 ? _tokens : _tokens * _supply / aToken.balanceOf(address(this));
L373: return _supply == 0 ? _shares : _shares * aToken.balanceOf(address(this)) / _supply;
Results in lesser gas usage ! (shown below)
Reason: starting Solidity >= 0.8.0, arithmetic operations revert on underflow and overflow.
OZ's SafeMath v4.4.1 for Solidity >= 0.8.0 relies on compiler's checks for sub, mul and div functions anyway, making the use of the library completely redundant.
with SafeMath:
·-------------------------------------------------------|----------------------------|-------------|-----------------------------· | Solc version: 0.8.10 · Optimizer enabled: false · Runs: 200 · Block limit: 30000000 gas │ ························································|····························|·············|······························ | Methods · 100 gwei/gas · 2772.21 usd/eth │ ·····························|··························|··············|·············|·············|···············|·············· | Contract · Method · Min · Max · Avg · # calls · usd (avg) │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · claimRewards · 57098 · 59291 · 58195 · 4 · 16.13 │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · decreaseERC20Allowance · 40154 · 42359 · 41620 · 3 · 11.54 │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · increaseERC20Allowance · 61935 · 64452 · 64041 · 7 · 17.75 │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · mint · 52265 · 69377 · 62788 · 13 · 17.41 │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · redeemToken · - · - · 116178 · 1 · 32.21 │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · setManager · - · - · 48335 · 4 · 13.40 │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · supplyTokenTo · 115041 · 157449 · 146161 · 6 · 40.52 │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · transferERC20 · 60271 · 62452 · 61362 · 2 · 17.01 │ ·····························|··························|··············|·············|·············|···············|·············· | ERC20Mintable · approve · 27329 · 47229 · 43912 · 6 · 12.17 │ ·····························|··························|··············|·············|·············|···············|·············· | ERC20Mintable · mint · 52286 · 69698 · 66593 · 12 · 18.46 │ ·····························|··························|··············|·············|·············|···············|·············· | ERC20Mintable · transferFrom · - · - · 50967 · 1 · 14.13 │ ·····························|··························|··············|·············|·············|···············|·············· | Deployments · · % of limit · │ ························································|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · 4670575 · 4670587 · 4670585 · 15.6 % · 1294.78 │ ························································|··············|·············|·············|···············|·············· | ERC20Mintable · - · - · 2256052 · 7.5 % · 625.42 │ ·-------------------------------------------------------|--------------|-------------|-------------|---------------|-------------·
after SafeMath removed and adjusted:
·-------------------------------------------------------|----------------------------|-------------|-----------------------------· | Solc version: 0.8.10 · Optimizer enabled: false · Runs: 200 · Block limit: 30000000 gas │ ························································|····························|·············|······························ | Methods · 100 gwei/gas · 2787.95 usd/eth │ ·····························|··························|··············|·············|·············|···············|·············· | Contract · Method · Min · Max · Avg · # calls · usd (avg) │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · claimRewards · 57098 · 59291 · 58195 · 4 · 16.22 │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · decreaseERC20Allowance · 40154 · 42359 · 41620 · 3 · 11.60 │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · increaseERC20Allowance · 61935 · 64452 · 64041 · 7 · 17.85 │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · mint · 52265 · 69377 · 62788 · 13 · 17.50 │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · redeemToken · - · - · 115989 · 1 · 32.34 │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · setManager · - · - · 48335 · 4 · 13.48 │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · supplyTokenTo · 114915 · 157449 · 146119 · 6 · 40.74 │ ·····························|··························|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · transferERC20 · 60271 · 62452 · 61362 · 2 · 17.11 │ ·····························|··························|··············|·············|·············|···············|·············· | ERC20Mintable · approve · 27329 · 47229 · 43912 · 6 · 12.24 │ ·····························|··························|··············|·············|·············|···············|·············· | ERC20Mintable · mint · 52286 · 69698 · 66593 · 12 · 18.57 │ ·····························|··························|··············|·············|·············|···············|·············· | ERC20Mintable · transferFrom · - · - · 50967 · 1 · 14.21 │ ·····························|··························|··············|·············|·············|···············|·············· | Deployments · · % of limit · │ ························································|··············|·············|·············|···············|·············· | AaveV3YieldSourceHarness · 4648841 · 4648853 · 4648851 · 15.5 % · 1296.08 │ ························································|··············|·············|·············|···············|·············· | ERC20Mintable · - · - · 2256052 · 7.5 % · 628.98 │ ·-------------------------------------------------------|--------------|-------------|-------------|---------------|-------------·
#0 - PierrickGT
2022-05-03T21:35:19Z
Great report by this warden, he should get extra points.
#1 - PierrickGT
2022-05-03T21:35:38Z