Platform: Code4rena
Start Date: 29/04/2022
Pot Size: $22,000 USDC
Total HM: 6
Participants: 40
Period: 3 days
Judge: Justin Goro
Total Solo HM: 2
Id: 114
League: ETH
Rank: 23/40
Findings: 1
Award: $82.42
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: IllIllI
Also found by: 0v3rf10w, 0x1f8b, 0x4non, 0xDjango, 0xf15ers, 0xkatana, 242, Dravee, GimelSec, MaratCerby, Tadashi, TrungOre, WatchPug, defsec, fatherOfBlocks, gzeon, hake, horsefacts, joestakey, miguelmtzinf, pauliax, pedroais, peritoflores, rotcivegaf, simon135, slywaters, tabish, throttle, z3s
82.4186 USDC - $82.42
The codebase of this audit comprises a single file AaveV3YieldSource.sol. The code is very well commented with full natspec documentation. The code is simple and easily readable.
Informational issues : -SafeMath is used for all arithmetic operations which is unnecessary since the contract was written in solidity 0.8.10. This makes the code harder to read. https://github.com/pooltogether/aave-v3-yield-source/blob/e63d1b0e396a5bce89f093630c282ca1c6627e44/contracts/AaveV3YieldSource.sol#L26
-In the redeem token function an event is emitted with emitAmount as a parameter instead of _balanceDiff which is the amount that is actually redeemed as we can see in the transfer done in line 263. https://github.com/pooltogether/aave-v3-yield-source/blob/e63d1b0e396a5bce89f093630c282ca1c6627e44/contracts/AaveV3YieldSource.sol#L265
#0 - PierrickGT
2022-05-04T19:55:17Z
-SafeMath is used for all arithmetic operations which is unnecessary since the contract was written in solidity 0.8.10
Duplicate of https://github.com/code-423n4/2022-04-pooltogether-findings/issues/11
In the redeem token function an event is emitted with emitAmount as a parameter instead of _balanceDiff which is the amount that is actually redeemed as we can see in the transfer done in line 263.
Duplicate of https://github.com/code-423n4/2022-04-pooltogether-findings/issues/22
#1 - JeeberC4
2022-05-23T16:32:17Z
Changing name to better reflect the judging outcome.