PoolTogether - 0xkeesmark's results

Lines of code

https://github.com/code-423n4/2024-03-pooltogether/blob/main/pt-v5-vault/src/PrizeVault.sol#L617

Vulnerability details

Summary

The claimYieldFeeShares function in the PrizeVault contract incorrectly reduces the yieldFeeBalance, leading to potential discrepancies in fee distribution.

Vulnerability Details

In the PrizeVault contract, the claimYieldFeeShares function is intended to reduce the yieldFeeBalance by the amount of yield fee shares being claimed. However, due to a typo, it incorrectly reduces the yieldFeeBalance by _yieldFeeBalance instead of_shares.

The affected line of code is as follows:

yieldFeeBalance -= _yieldFeeBalance; // Incorrect

The correct implementation should be:

yieldFeeBalance -= _shares; // Correct

https://github.com/code-423n4/2024-03-pooltogether/blob/main/pt-v5-vault/src/PrizeVault.sol#L617

Impact

The incorrect reduction of yieldFeeBalance can lead to an inaccurate accounting of yield fees within the contract. This discrepancy can result in unfair distribution of yield fees among participants, potentially disadvantaging some users while unfairly benefiting others. Over time, this could undermine trust in the platform and affect the overall integrity and fairness of fee distribution.

Tools Used

Manual review

Recommendations

To resolve this issue, the following code change is recommended:

- yieldFeeBalance -= _yieldFeeBalance;
+ yieldFeeBalance -= _shares;

Assessed type

Math