Platform: Code4rena
Start Date: 04/03/2024
Pot Size: $36,500 USDC
Total HM: 9
Participants: 80
Period: 7 days
Judge: hansfriese
Total Solo HM: 2
Id: 332
League: ETH
Rank: 70/80
Findings: 1
Award: $1.47
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: DarkTower
Also found by: 0xJaeger, 0xJoyBoy03, 0xRiO, 0xkeesmark, 0xlemon, 0xmystery, Abdessamed, AcT3R, Afriauditor, AgileJune, Al-Qa-qa, Aymen0909, Daniel526, DanielTan_MetaTrust, Dots, FastChecker, Fitro, GoSlang, Greed, Krace, McToady, SoosheeTheWise, Tripathi, asui, aua_oo7, btk, crypticdefense, d3e4, dd0x7e8, dvrkzy, gesha17, iberry, kR1s, leegh, marqymarq10, n1punp, pa6kuda, radin100, sammy, smbv-1923, trachev, turvy_fuzz, valentin_s2304, wangxx2026, y4y, yotov721, yvuchev, zhaojie
1.4652 USDC - $1.47
The claimYieldFeeShares function sets yieldFeeBalance to zero, regardless of the quantity of shares. As a result, the client loses all his yieldFeeBalance.
For example, if a person has plenty of shares but decides to deposit only 1 in the claimYieldFeeShares function, all his yieldFeeBalance will be lost and set to 0.
Manual Review
- yieldFeeBalance -= _yieldFeeBalance; + yieldFeeBalance -= _shares;
By subtracting the _shares, the yield fee recipient will not lose all his yieldFeeBalance and any other balance will be filtered.
Error
#0 - c4-pre-sort
2024-03-11T21:38:10Z
raymondfam marked the issue as sufficient quality report
#1 - c4-pre-sort
2024-03-11T21:38:16Z
raymondfam marked the issue as duplicate of #10
#2 - c4-pre-sort
2024-03-13T04:38:07Z
raymondfam marked the issue as duplicate of #59
#3 - c4-judge
2024-03-15T07:37:30Z
hansfriese changed the severity to 3 (High Risk)
#4 - c4-judge
2024-03-15T07:40:41Z
hansfriese marked the issue as satisfactory