Ondo Finance - Aamir's results

Institutional-Grade Finance, Now Onchain.

General Information

Platform: Code4rena

Start Date: 29/03/2024

Pot Size: $36,500 USDC

Total HM: 5

Participants: 72

Period: 5 days

Judge: 3docSec

Total Solo HM: 1

Id: 357

League: ETH

Ondo Finance

Findings Distribution

Researcher Performance

Rank: 62/72

Findings: 1

Award: $8.28

🌟 Selected for report: 0

🚀 Solo Findings: 0

Lines of code

https://github.com/code-423n4/2024-03-ondo-finance/blob/78779c30bebfd46e6f416b03066c55d587e8b30b/contracts/ousg/ousgInstantManager.sol#L49

Vulnerability details

The absence of a minimum amount parameter for slippage in the ousgInstantManager.sol contract poses a risk of token loss to users in case of price fluctuations prior to transaction execution.

Impact

Functions within ousgInstantManager.sol lack a crucial parameter, minAmount, during minting or redemption processes. This parameter is pivotal in mitigating slippage risks caused by adverse price movements. The oversight increases the vulnerability of users to potential token loss.

Proof of Concept

No minimum amount parameter in the following functions 👇

https://github.com/code-423n4/2024-03-ondo-finance/blob/78779c30bebfd46e6f416b03066c55d587e8b30b/contracts/ousg/ousgInstantManager.sol#L230

https://github.com/code-423n4/2024-03-ondo-finance/blob/78779c30bebfd46e6f416b03066c55d587e8b30b/contracts/ousg/ousgInstantManager.sol#L335

https://github.com/code-423n4/2024-03-ondo-finance/blob/78779c30bebfd46e6f416b03066c55d587e8b30b/contracts/ousg/ousgInstantManager.sol#L254

https://github.com/code-423n4/2024-03-ondo-finance/blob/78779c30bebfd46e6f416b03066c55d587e8b30b/contracts/ousg/ousgInstantManager.sol#L362

Tools Used

  • Manual Review

It is recommended to add minAmount parameter in all of the functions.

Assessed type

Other

#0 - c4-pre-sort

2024-04-04T02:58:54Z

0xRobocop marked the issue as duplicate of #250

#1 - c4-pre-sort

2024-04-04T22:59:52Z

0xRobocop marked the issue as duplicate of #156

#2 - c4-judge

2024-04-09T08:02:06Z

3docSec marked the issue as satisfactory

#3 - c4-judge

2024-04-11T15:13:13Z

3docSec changed the severity to QA (Quality Assurance)

#4 - c4-judge

2024-04-11T15:16:30Z

3docSec marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter