Ondo Finance - jaydhales's results

Lines of code

https://github.com/code-423n4/2024-03-ondo-finance/blob/main/contracts/ousg/ousgInstantManager.sol#L554-L573

Vulnerability details

Impact

In setMintFee and setRedeemFee, The require statements check against the state variables and not the parameters _mintFee and _redeemFee`.

This means that mintFee and redeemFee can be set to be above 200. Once set, The Configurer will not be able to change them again as the require statement will fail.

Recommended Mitigation Steps

Change mintFee and redeemFee to _mintFee and _redeemFee in #L557 and #L570 respectively

  function setMintFee(
    uint256 _mintFee
  ) external override onlyRole(CONFIGURER_ROLE) {
    require(_mintFee < 200, "OUSGInstantManager::setMintFee: Fee too high");
    emit MintFeeSet(mintFee, _mintFee);
    mintFee = _mintFee;
  }

  function setRedeemFee(
    uint256 _redeemFee
  ) external override onlyRole(CONFIGURER_ROLE) {
    require(_redeemFee < 200, "OUSGInstantManager::setRedeemFee: Fee too high");
    emit RedeemFeeSet(redeemFee, _redeemFee);
    redeemFee = _redeemFee;
  }

Assessed type

DoS