Platform: Code4rena
Start Date: 20/09/2022
Pot Size: $100,000 USDC
Total HM: 4
Participants: 109
Period: 7 days
Judge: GalloDaSballo
Id: 163
League: ETH
Rank: 98/109
Findings: 1
Award: $55.20
đ Selected for report: 0
đ Solo Findings: 0
đ Selected for report: IllIllI
Also found by: 0x1f8b, 0x4non, 0x52, 0x5rings, 0xNazgul, 0xRobocop, 0xSmartContract, 0xdeadbeef, 0xsanson, 8olidity, Amithuddar, Aymen0909, B2, B353N, CertoraInc, Ch_301, Chom, CodingNameKiki, Deivitto, ElKu, Funen, JC, JohnnyTime, Kresh, Lambda, Noah3o6, RaymondFam, ReyAdmirado, RockingMiles, Rolezn, Sm4rty, SuldaanBeegsi, Tadashi, TomJ, Tomio, V_B, Waze, __141345__, a12jmx, ak1, arcoun, asutorufos, aviggiano, berndartmueller, bharg4v, bin2chen, brgltd, bulej93, c3phas, catchup, cccz, ch0bu, cryptonue, cryptphi, csanuragjain, delfin454000, devtooligan, djxploit, durianSausage, eighty, erictee, exd0tpy, fatherOfBlocks, giovannidisiena, hansfriese, ignacio, joestakey, ladboy233, lukris02, m9800, malinariy, martin, minhtrng, obront, oyc_109, pedr02b2, pedroais, pfapostol, philogy, prasantgupta52, rbserver, ronnyx2017, rotcivegaf, rvierdiiev, sach1r0, shung, simon135, throttle, tnevler, tonisives, wagmi, yixxas, zkhorse, zzykxx, zzzitron
55.1985 USDC - $55.20
Missing zero address check can lead to unintended issues, which may cause re-deployment of the contract.
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L316
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L316
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/Pages.sol#L181
Block timestamps have historically been used for a variety of applications, such as entropy for random numbers, locking funds for periods of time, and various state-changing conditional statements that are time-dependent. Miners have the ability to adjust timestamps slightly, which can prove to be dangerous if block timestamps are used incorrectly in smart contracts.
Navigate to the following contracts.
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L341
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L399
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L455
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L513
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L661
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L763
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L826
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L904
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L911
Contracts are allowed to override their parentsâ functions and change the visibility from external to public
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/utils/token/GobblersERC1155B.sol#L79
Each event should use three indexed fields if there are three or more fields
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L232
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L233
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L234
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L240
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/Pages.sol#L134
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/Pages.sol#L136
Use specific compilers in the pragma. Compilers should be locked to a particular version
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/Goo.sol
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/utils/GobblerReserve.sol
https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/utils/token/GobblersERC721.sol
#0 - GalloDaSballo
2022-10-04T22:05:22Z
L
Disputed as it lack nuance
NC
Disputed for the instances linked
NC
Usual findings
1L 2NC