Art Gobblers contest - fatherOfBlocks's results

Experimental Decentralized Art Factory By Justin Roiland and Paradigm.

General Information

Platform: Code4rena

Start Date: 20/09/2022

Pot Size: $100,000 USDC

Total HM: 4

Participants: 109

Period: 7 days

Judge: GalloDaSballo

Id: 163

League: ETH

Art Gobblers

Findings Distribution

Researcher Performance

Rank: 59/109

Findings: 1

Award: $55.20

🌟 Selected for report: 0

🚀 Solo Findings: 0

lib/solmate/src/tokens/ERC721.sol

  • The contract does not comply with the EIP 721 standard, therefore, in order not to generate confusion, it should have another name. Among the modifications are: changes in the names of the inputs and functions such as balanceOf() and ownerOf() that are public when in the ERC721 standard they are external.

  • The functions ownerOf() and balanceOf() are public but they are not used in any function of the contract, also if the contract that inherits this abstract contract wants to consult these two data, it would be less expensive directly doing it in the variables in storage and not through of a function

lib/VRGDAs/src/LogisticToLinearVRGDA.sol

  • L6 - It is not necessary to import VRGDA, since it is not used in the entire contract, this generates unnecessary gas costs in the deploy.

lib/goo-issuance/src/LibGOO.sol

  • The library in general does not return any value that is useful to obtain something, since the only function it has receives an input and returns it, but first it executes code to define variables that are never used.

#0 - GalloDaSballo

2022-10-14T00:32:46Z

The contract does not comply with the EIP 721 standard

A public function is also external, this is not valid

The functions ownerOf() and balanceOf() are public

R

L6 - It is not necessary to import VRGDA

R, nice catch!

The library in general does not return any value that is useful to obtain something,

Disagree code looks fine

Neat report

2R

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter