Platform: Code4rena
Start Date: 20/09/2022
Pot Size: $100,000 USDC
Total HM: 4
Participants: 109
Period: 7 days
Judge: GalloDaSballo
Id: 163
League: ETH
Rank: 104/109
Findings: 1
Award: $55.20
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: IllIllI
Also found by: 0x1f8b, 0x4non, 0x52, 0x5rings, 0xNazgul, 0xRobocop, 0xSmartContract, 0xdeadbeef, 0xsanson, 8olidity, Amithuddar, Aymen0909, B2, B353N, CertoraInc, Ch_301, Chom, CodingNameKiki, Deivitto, ElKu, Funen, JC, JohnnyTime, Kresh, Lambda, Noah3o6, RaymondFam, ReyAdmirado, RockingMiles, Rolezn, Sm4rty, SuldaanBeegsi, Tadashi, TomJ, Tomio, V_B, Waze, __141345__, a12jmx, ak1, arcoun, asutorufos, aviggiano, berndartmueller, bharg4v, bin2chen, brgltd, bulej93, c3phas, catchup, cccz, ch0bu, cryptonue, cryptphi, csanuragjain, delfin454000, devtooligan, djxploit, durianSausage, eighty, erictee, exd0tpy, fatherOfBlocks, giovannidisiena, hansfriese, ignacio, joestakey, ladboy233, lukris02, m9800, malinariy, martin, minhtrng, obront, oyc_109, pedr02b2, pedroais, pfapostol, philogy, prasantgupta52, rbserver, ronnyx2017, rotcivegaf, rvierdiiev, sach1r0, shung, simon135, throttle, tnevler, tonisives, wagmi, yixxas, zkhorse, zzykxx, zzzitron
55.1985 USDC - $55.20
First issue:
Use OpenZeppelin - ArtGobblers.sol
The lines 62-68 are import lines were the developers have imported Owned.sol, ERC721.sol etc. These contracts can be also found in the OpenZeppelin library, which is the industry standard. When thinking of smart contract developing, we have to have longevity in mind. OpenZeppelin is a large organization with multiple years of experience in developing a open source library. I am fan of the developer of soulmate, but longevity in mind it is best for the projects lifespan to use OpenZeppelin library.
Second issue:
The use of Solmate header folding brakes when using vscode as the editor and from looking at the discord chat it breaks for other editors ex jetbrains.
Third issue: line 844 - ArtGobblers.sol
uint256 newNumMintedForReserves = numMintedForReserves += (numGobblersEach << 1);
The left shift could be replaced by mul.
P.S thanks for the free C4
#0 - GalloDaSballo
2022-10-06T00:33:18Z
Disagree with first 2
1 R