Art Gobblers contest - JohnnyTime's results

Experimental Decentralized Art Factory By Justin Roiland and Paradigm.

General Information

Platform: Code4rena

Start Date: 20/09/2022

Pot Size: $100,000 USDC

Total HM: 4

Participants: 109

Period: 7 days

Judge: GalloDaSballo

Id: 163

League: ETH

Art Gobblers

Findings Distribution

Researcher Performance

Rank: 102/109

Findings: 1

Award: $55.20

🌟 Selected for report: 0

🚀 Solo Findings: 0

Missing checks for address(0x0) when assigning values to address state variables in constructors

Affected Contracts

  • GobblerReserve.sol#24
  • PagesERC721.sol#44
  • Pages.sol#180-181
  • Goo.sol#83-84
  • ArtGoobles.sol#314-318

Description

Zero-address checks are a best practice for input validation of critical address parameters. While the codebase applies this to most cases, there are many places where this is missing in constructors and setters.

Impact

Accidental use of zero-addresses may result in exceptions, burn fees/tokens, or force redeployment of contracts.

Mitigation

In the functions mentioned above, add the following require statement before setting variables:

require(var != address(0), "var is the zero address");

#0 - GalloDaSballo

2022-10-06T00:16:31Z

1L

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter