AbraNFT contest - Hawkeye's results

A peer to peer lending platform, using NFTs as collateral.

General Information

Platform: Code4rena

Start Date: 27/04/2022

Pot Size: $50,000 MIM

Total HM: 6

Participants: 59

Period: 5 days

Judge: 0xean

Id: 113

League: ETH

Abracadabra Money

Findings Distribution

Researcher Performance

Rank: 59/59

Findings: 1

Award: $43.87

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

43.8655 MIM - $43.87

Labels

bug
G (Gas Optimization)
sponsor disputed

External Links

State variable is already cached.

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L491

Therefore, move to Line 490 and use as the divisor instead of YEAR_BPS:

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L490

Also, within the loop, there's no need to access YEAR_BPS in the addition assignment denom_k based on the aforementioned.

Change :

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L495

to :

denom_k+=denom_k;

#0 - cryptolyndon

2022-05-13T05:56:57Z

This change would break things.

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter