AbraNFT contest - Funen's results

1. Title : Typo Comment

This was typo comment, it should be calculateinterest instead of calculateIntest.

##Tool Used Manual Review

2. Title : Consistency code for easy readibilty

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L188-L191

since this worse params was used, it can be used like below :

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L283-L288

##Tool Used Manual Review

##Recommended Mitigation

            require(
                params.duration >= cur.duration &&
                params.valuation <= cur.valuation &&
                params.annualInterestBPS <= cur.annualInterestBPS,
                "NFTPair: worse params"
            );

1. Title : Using ++i than i++ for saving more gas

Using i++ instead ++i for all the loops, the variable i is incremented using i++. It is known that implementation by using ++i costs less gas per iteration than i++.

Tools Used

Manual Review, Remix

Occurances

main/contracts/NFTPair.sol#L494
main/contracts/NFTPair.sol#L631

2. Title : change uint256 i = 0 into uint i for saving more gas

using this implementation can saving more gas for each loops.

##Tool Used Manual Review & Remix

##Recommended Mitigation Change it

##Occurances

main/contracts/NFTPair.sol#L631

3. Saving gas by removing = 0

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L719

If a variable was not set/initialized, it is assumed to have default value to 0 this implementation was used for saving more gas by removing = 0

##TOOLS USED Remix, Manual Review

##Mitigation Step Remove = 0