AbraNFT contest - delfin454000's results

Typos

The same typo (inquality) occurs in both lines below:

    /// of the above inquality) fits in 128 bits, then the function is

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L434

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPairWithOracle.sol#L467

Change inquality to inequality

The same typo (initialised) occurs in both lines below:

    /// @notice Subsequent clones are initialised via `init`.

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L168

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPairWithOracle.sol#L185

Change initialised to initialized

6 instances of the same typo (..) occur in the lines below:

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L107

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L264

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L311

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPairWithOracle.sol#L124

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPairWithOracle.sol#L293

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPairWithOracle.sol#L346

Change .. to . or to ... if that was what was intended

8 instances of the same typo (transfered) occur in the lines below:

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L233

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L320

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L351

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L394

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPairWithOracle.sol#L253

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPairWithOracle.sol#L355

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPairWithOracle.sol#L386

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPairWithOracle.sol#L428

Change transfered to transferred

Issue: Require message too long Explanation: The require message below can be shortened to 32 characters or fewer (as shown) to save gas.

The same long message occurs in both lines referenced below: https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L366 https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPairWithOracle.sol#L398

            require(ILendingClub(lender).willLend(tokenId, params), "NFTPair: LendingClub does not like you");	

Change NFTPair: LendingClub does not like you to NFTPair: LendingClub loathes you

Issue: Use of && within a require function Explanation: Dividing the require into separate require messages instead of using && will save gas.

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L188-L191

            require(
                params.duration >= cur.duration && params.valuation <= cur.valuation && params.annualInterestBPS <= cur.annualInterestBPS,
                "NFTPair: worse params"
            );    	

Change to:

            require(params.duration >= cur.duration, "NFTPair: worse params");		
            require(params.valuation <= cur.valuation, "NFTPair: worse params");		
            require(params.annualInterestBPS <= cur.annualInterestBPS, "NFTPair: worse params");		

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPairWithOracle.sol#L205-L211

            require(
                params.duration >= cur.duration &&
                    params.valuation <= cur.valuation &&
                    params.annualInterestBPS <= cur.annualInterestBPS &&
                    params.ltvBPS <= cur.ltvBPS,
                "NFTPair: worse params"
            ); 	

Change to:

            require(params.duration >= cur.duration, "NFTPair: worse params");		
            require(params.valuation <= cur.valuation, "NFTPair: worse params");		
            require(params.annualInterestBPS <= cur.annualInterestBPS, "NFTPair: worse params");		
            require(params.ltvBPS <= cur.ltvBPS, "NFTPair: worse params");		

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L283-L288

        require(
            params.valuation == accepted.valuation &&
                params.duration <= accepted.duration &&
                params.annualInterestBPS >= accepted.annualInterestBPS,
            "NFTPair: bad params"
        );	

Change to:

        require(params.valuation == accepted.valuation, "NFTPair: bad params");		
        require(params.duration <= accepted.duration, "NFTPair: bad params");		
        require(params.annualInterestBPS >= accepted.annualInterestBPS, "NFTPair: bad params");		

https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPairWithOracle.sol#L312-L318

        require(
            params.valuation == accepted.valuation &&
                params.duration <= accepted.duration &&
                params.annualInterestBPS >= accepted.annualInterestBPS &&
                params.ltvBPS >= accepted.ltvBPS,
            "NFTPair: bad params"
        );	

Change to:

        require(params.valuation == accepted.valuation, "NFTPair: bad params");		
        require(params.duration <= accepted.duration, "NFTPair: bad params");		
        require(params.annualInterestBPS >= accepted.annualInterestBPS, "NFTPair: bad params");		
        require(params.ltvBPS >= accepted.ltvBPS, "NFTPair: bad params");		

The require function with embedded '&&' occurs in both lines referenced below: https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L622 https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPairWithOracle.sol#L655

        require(callee != address(bentoBox) && callee != address(collateral) && callee != address(this), "NFTPair: can't call");		

Change to:

        require(callee != address(bentoBox), "NFTPair: can't call");		
        require(callee != address(collateral), "NFTPair: can't call");	
        require(callee != address(this), "NFTPair: can't call");		

Issue: Variables should not be initialized to their default values Explanation: Initializing uint variables to their default value of 0 is unnecessary and costs gas.

The same initialization of a variable to its default occurs in both lines referenced below: https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPair.sol#L96 https://github.com/code-423n4/2022-04-abranft/blob/5cd4edc3298c05748e952f8a8c93e42f930a78c2/contracts/NFTPairWithOracle.sol#L113

    uint8 private constant LOAN_INITIAL = 0;		

Change LOAN_INITIAL = 0; to LOAN_INITIAL;