AbraNFT contest - 0x1f8b's results

A peer to peer lending platform, using NFTs as collateral.

General Information

Platform: Code4rena

Start Date: 27/04/2022

Pot Size: $50,000 MIM

Total HM: 6

Participants: 59

Period: 5 days

Judge: 0xean

Id: 113

League: ETH

Abracadabra Money

Findings Distribution

Researcher Performance

Rank: 34/59

Findings: 2

Award: $116.34

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

72.4084 MIM - $72.41

Labels

bug
QA (Quality Assurance)
sponsor disputed

External Links

. Bad coding practices:

  • One file per class or one file per contract, is always a good practice that facilitates readability and auditability. example: BentoBoxFlat
  1. Lack of input checks:

#0 - cryptolyndon

2022-05-12T03:58:15Z

  • The BentoBox is not only out of scope, it is not part of the project. That file serves as a reference only, and as a base for the mock BentoBox we use for testing.
  • The zero check on collateral is not to somehow check that parameter; it is to ensure init() cannot be called twice.

Awards

43.9319 MIM - $43.93

Labels

G (Gas Optimization)
sponsor disputed

External Links

#0 - cryptolyndon

2022-05-13T23:12:58Z

I flat out refuse to believe this makes a difference. Disputing since that's all that's in the report

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter