Kelp DAO | rsETH - Noro's results

A collective DAO designed to unlock liquidity, DeFi and higher rewards for restaked assets through liquid restaking.

General Information

Platform: Code4rena

Start Date: 10/11/2023

Pot Size: $28,000 USDC

Total HM: 5

Participants: 185

Period: 5 days

Judge: 0xDjango

Id: 305

League: ETH

Kelp DAO

Findings Distribution

Researcher Performance

Rank: 155/185

Findings: 1

Award: $2.76

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

2.7592 USDC - $2.76

Labels

bug
downgraded by judge
grade-b
QA (Quality Assurance)
sufficient quality report
duplicate-294
Q-85

External Links

Lines of code

https://github.com/code-423n4/2023-11-kelp/blob/main/src/RSETH.sol#L47 https://github.com/code-423n4/2023-11-kelp/blob/main/src/NodeDelegator.sol#L51

Vulnerability details

Funds received from users deposits in LRTDepositPool are then transfered to NodeDelegator to delegate them to EigenLayer in order to generate yield . The problem here is that there is not a way to increase users RSETH balance or minting new tokens to users when a new yield is generated .

Impact

Users will not get yield generated by their funds in EigenLayer .

Proof of Concept

LRTDepositPool is the only to have MINTER_ROLE to mint new RSETH, but it does’t have a function to mint to users when they generated yield , it only mints when they deposit . Also RSETH balanceOf() function can’t be manipulated to increase the users balance when they generate yield .

Tools Used

Manual Review

increase users RSETH balance when their deposits generate yield from EigenLayer .

Assessed type

Other

#0 - c4-pre-sort

2023-11-16T03:44:21Z

raymondfam marked the issue as insufficient quality report

#1 - c4-pre-sort

2023-11-16T03:44:34Z

raymondfam marked the issue as duplicate of #43

#2 - c4-pre-sort

2023-11-16T22:01:25Z

raymondfam marked the issue as not a duplicate

#3 - c4-pre-sort

2023-11-16T22:01:37Z

raymondfam marked the issue as duplicate of #709

#4 - c4-pre-sort

2023-11-17T22:28:09Z

raymondfam marked the issue as duplicate of #294

#5 - c4-pre-sort

2023-11-17T22:28:37Z

raymondfam marked the issue as sufficient quality report

#6 - c4-judge

2023-12-01T17:41:33Z

fatherGoose1 marked the issue as unsatisfactory: Invalid

#7 - c4-judge

2023-12-06T18:19:18Z

fatherGoose1 changed the severity to QA (Quality Assurance)

#8 - c4-judge

2023-12-08T18:52:40Z

fatherGoose1 marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter