Kelp DAO | rsETH - zhaojohnson's results

A collective DAO designed to unlock liquidity, DeFi and higher rewards for restaked assets through liquid restaking.

General Information

Platform: Code4rena

Start Date: 10/11/2023

Pot Size: $28,000 USDC

Total HM: 5

Participants: 185

Period: 5 days

Judge: 0xDjango

Id: 305

League: ETH

Kelp DAO

Findings Distribution

Researcher Performance

Rank: 135/185

Findings: 1

Award: $2.76

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

2.7592 USDC - $2.76

Labels

bug
downgraded by judge
grade-b
insufficient quality report
QA (Quality Assurance)
duplicate-70
Q-119

External Links

Lines of code

https://github.com/code-423n4/2023-11-kelp/blob/c5fdc2e62c5e1d78769f44d6e34a6fb9e40c00f0/src/NodeDelegator.sol#L38-L46

Vulnerability details

Impact

eigenlayerStrategyManager will have the approval to transfer all funds in nodeDelegator after maxApproveToEigenStrategyManager(). If admin updates one new eigenlayerStrategyManager, deprecated eigenlayerStrategyManager still owns max approval to transfer funds.

Proof of Concept

https://github.com/code-423n4/2023-11-kelp/blob/c5fdc2e62c5e1d78769f44d6e34a6fb9e40c00f0/src/NodeDelegator.sol#L38-L46 https://github.com/code-423n4/2023-11-kelp/blob/c5fdc2e62c5e1d78769f44d6e34a6fb9e40c00f0/src/LRTConfig.sol#L165-L179

Admin should cancel deprecated eigenlayerStrategyManager's approval.

Tools Used

Manual

Assessed type

Other

#0 - c4-pre-sort

2023-11-15T22:35:53Z

raymondfam marked the issue as insufficient quality report

#1 - c4-pre-sort

2023-11-15T22:36:06Z

raymondfam marked the issue as duplicate of #70

#2 - c4-judge

2023-11-29T19:28:16Z

fatherGoose1 changed the severity to QA (Quality Assurance)

#3 - c4-judge

2023-11-29T19:28:36Z

fatherGoose1 marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter