Kelp DAO | rsETH - poneta's results

A collective DAO designed to unlock liquidity, DeFi and higher rewards for restaked assets through liquid restaking.

General Information

Platform: Code4rena

Start Date: 10/11/2023

Pot Size: $28,000 USDC

Total HM: 5

Participants: 185

Period: 5 days

Judge: 0xDjango

Id: 305

League: ETH

Kelp DAO

Findings Distribution

Researcher Performance

Rank: 183/185

Findings: 1

Award: $2.76

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

2.7592 USDC - $2.76

Labels

bug
downgraded by judge
grade-b
QA (Quality Assurance)
sufficient quality report
duplicate-723
Q-19

External Links

Lines of code

https://github.com/code-423n4/2023-11-kelp/blob/f751d7594051c0766c7ecd1e68daeb0661e43ee3/src/oracles/ChainlinkPriceOracle.sol#L37-L38

Vulnerability details

Vulnerability Details

Price Feeds that are taken from oracles (in this case - chainlink) depend entirely on that oracle for prices. In case of a manipulated oracle price feed, an arbitrage opportunity will be introduced, which could be taken advantage of, draining all the suported assets from the protocol.

https://github.com/code-423n4/2023-11-kelp/blob/f751d7594051c0766c7ecd1e68daeb0661e43ee3/src/oracles/ChainlinkPriceOracle.sol#L37-L38

Tools Used

Manual Review

Avoid dependency on a single oracle price feed so that if any one of the price feeds does get manipulated, the oracle can continue receving prices from the rest of the oracles.

Assessed type

Oracle

#0 - c4-pre-sort

2023-11-16T22:34:58Z

raymondfam marked the issue as sufficient quality report

#1 - c4-pre-sort

2023-11-16T22:35:08Z

raymondfam marked the issue as duplicate of #32

#2 - c4-pre-sort

2023-11-17T04:39:37Z

raymondfam marked the issue as not a duplicate

#3 - c4-pre-sort

2023-11-17T04:39:52Z

raymondfam marked the issue as duplicate of #194

#4 - c4-pre-sort

2023-11-17T07:36:41Z

raymondfam marked the issue as duplicate of #723

#5 - c4-judge

2023-12-01T17:38:31Z

fatherGoose1 changed the severity to QA (Quality Assurance)

#6 - c4-judge

2023-12-01T18:42:55Z

fatherGoose1 marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter