Platform: Code4rena
Start Date: 10/11/2023
Pot Size: $28,000 USDC
Total HM: 5
Participants: 185
Period: 5 days
Judge: 0xDjango
Id: 305
League: ETH
Rank: 172/185
Findings: 1
Award: $2.76
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: m_Rassska
Also found by: 0x1337, 0xAadi, 0xHelium, 0xLeveler, 0xblackskull, 0xbrett8571, 0xepley, 0xffchain, 0xluckhu, 0xmystery, 0xrugpull_detector, 0xvj, ABAIKUNANBAEV, Aamir, AerialRaider, Amithuddar, Bauchibred, Bauer, CatsSecurity, Cryptor, Daniel526, Draiakoo, Eigenvectors, ElCid, GREY-HAWK-REACH, Inspecktor, Juntao, King_, LinKenji, Madalad, MaslarovK, Matin, MatricksDeCoder, McToady, Noro, PENGUN, Pechenite, Phantasmagoria, RaoulSchaffranek, SBSecurity, SandNallani, Shaheen, Soul22, Stormreckson, T1MOH, Tadev, TeamSS, TheSchnilch, Topmark, Tumelo_Crypto, Udsen, Yanchuan, ZanyBonzy, _thanos1, adeolu, adriro, alexfilippov314, almurhasan, amaechieth, anarcheuz, ayden, baice, bareli, boredpukar, bronze_pickaxe, btk, cartlex_, catellatech, chaduke, cheatc0d3, circlelooper, codynhat, crack-the-kelp, critical-or-high, debo, deepkin, desaperh, dipp, eeshenggoh, evmboi32, ge6a, gesha17, glcanvas, gumgumzum, hals, hihen, hunter_w3b, jasonxiale, joaovwfreire, ke1caM, leegh, lsaudit, marchev, merlinboii, niser93, osmanozdemir1, paritomarrr, passion, pep7siup, phoenixV110, pipidu83, poneta, ro1sharkm, rouhsamad, rvierdiiev, sakshamguruji, seerether, shealtielanz, soliditytaker, spark, squeaky_cactus, stackachu, supersizer0x, tallo, taner2344, turvy_fuzz, twcctop, ubl4nk, wisdomn_, xAriextz, zach, zhaojie, zhaojohnson, ziyou-
2.7592 USDC - $2.76
Although low risk as deposit limit is said to be 100 000 Eth, this will cause problems when interacting with Eigenlayer contracts as they share similar deposit limit.
stETH is a rebasing token that can increase or decrease as the balance of Eth in certain pools changes to maintain 1:1 peg. Should total deposits reach limit specified at any time and stETH supply increases, the protocol will be over the deposit Limit and could encounter problems interacting with the Eignelayer contracts as they are said to have a similar limit.
if (depositAmount > getAssetCurrentLimit(asset)) { revert MaximumDepositLimitReached(); }
Likelihood of this happening is low as protocol would have to reach or come really close to deposit limit of 100K ETH first.
Manuel review
Protocol should include separate checks to see if changes in stETH have pushed past depositLimit before depositing into NodeDelegator or EigenLayer strategies. If limit has been passed then protocol should remove some stETH from contract to remain under or equal to depositLimit.
#0 - raymondfam
2023-11-18T00:08:44Z
Possible upgrade:
[L-01] --> #537
#1 - c4-pre-sort
2023-11-18T00:08:51Z
raymondfam marked the issue as sufficient quality report
#2 - c4-judge
2023-12-01T16:42:15Z
fatherGoose1 marked the issue as grade-c
#3 - c4-judge
2023-12-01T18:56:57Z
fatherGoose1 marked the issue as grade-b
#4 - fatherGoose1
2023-12-01T18:57:12Z
Bumping to grade B due to dupe with #537