bunker.finance contest - dirk_y's results

The easiest way to borrow against your NFTs.

General Information

Platform: Code4rena

Start Date: 03/05/2022

Pot Size: $50,000 USDC

Total HM: 4

Participants: 46

Period: 5 days

Judge: gzeon

Total Solo HM: 2

Id: 117

League: ETH

bunker.finance

Findings Distribution

Researcher Performance

Rank: 30/46

Findings: 1

Award: $114.33

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

114.326 USDC - $114.33

Labels

bug
QA (Quality Assurance)

External Links

Low severity findings

Through my audit of this project I have found 2 low priority findings that I think are worth calling out:

  1. The borrow guardian is incorrectly set to "not-paused", in direct conflict to the comment above (see here). The code should be corrected to:
borrowGuardianPaused[address(cNft)] = true;
  1. _changeAdmin in Comptroller here should have a require statement to guard against the 0 address (require(newAdmin != address(0)) and ideally should have a propose-accept pattern to protect against assigning admin rights to the wrong address by accident

#0 - bunkerfinance-dev

2022-05-18T06:41:58Z

This report was useful to us.

#1 - gzeoneth

2022-05-29T13:20:50Z

Nice catch re:borrowGuardianPaused

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter