Platform: Code4rena
Start Date: 18/05/2023
Pot Size: $24,500 USDC
Total HM: 3
Participants: 72
Period: 4 days
Judge: LSDan
Id: 237
League: ETH
Rank: 63/72
Findings: 1
Award: $16.19
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: ABA
Also found by: 0x4non, 0xHati, 0xMosh, 0xSmartContract, 0xWaitress, 0xhacksmithh, 0xnev, 0xprinc, Arabadzhiev, BLACK-PANDA-REACH, Deekshith99, Dimagu, KKat7531, Kose, LosPollosHermanos, MohammedRizwan, QiuhaoLi, RaymondFam, Rickard, Rolezn, SAAJ, Sathish9098, Shubham, SmartGooofy, Tripathi, Udsen, V1235816, adriro, arpit, ayden, bigtone, codeVolcan, d3e4, dwward3n, fatherOfBlocks, favelanky, jovemjeune, kutugu, lfzkoala, lukris02, matrix_0wl, minhquanym, ni8mare, parsely, pxng0lin, radev_sw, ravikiranweb3, rbserver, sces60107, souilos, tnevler, turvy_fuzz, yellowBirdy
16.1907 USDC - $16.19
L4/8 - IJBController3_1, IJBFundingCycleBallot are imported, which are not used in any way, this generates that when the interface is deployed in a blockchain and in an explorer the entire code is seen, it becomes difficult to understand the code. In addition to the extra cost of gas that is generated.
L185/218 - The understanding of the code could be improved if a modifier were created so that it is clear who is authorized to use the function.
modifier onlyAddress(bool) { if(bool == true){ if (msg.sender != address(jbxTerminal)) revert JuiceBuyback_Unauthorized(); }else{ if (msg.sender != address(pool)) revert JuiceBuyback_Unauthorized(); } }
#0 - c4-judge
2023-06-02T10:56:47Z
dmvt marked the issue as grade-b