Juicebox Buyback Delegate - tnevler's results

Report

Low Risk

[L-1]: Missing checks for address(0x0)

Context:

1. projectToken = _projectToken; L124
2. pool = _pool; L125
3. _projectTokenIsZero = address(_projectToken) < address(_weth); L127
4. weth = _weth; L128

Recommendation:

Add non-zero address checks when set address state variables.

Non-Critical Issues

[N-1]: Empty blocks should be removed or Emit something

Context:

1. function redeemParams(JBRedeemParamsData calldata _data) L235

Description:

Code contains empty block

[N-2]: Missing leading underscores in constant name

Context:

1. uint256 private constant SLIPPAGE_DENOMINATOR = 10000; L68

Description:

Internal and private functions, state variables, constants, and immutables should starting with an underscore.

[N-3]: Unused imports

Context:

import "@openzeppelin/contracts/access/Ownable.sol"; L15