Juicebox Buyback Delegate - pxng0lin's results

Issues

Immutable address arguments provided to the constructor are missing zero address checks this could result in unexpected behavior when attempting to use the contract.

Link to code

File: juice-buyback/contracts/JBXBuybackDelegate.sol

124:    projectToken = _projectToken;
125:    pool = _pool;
126:    jbxTerminal = _jbxTerminal;
127:    ...
128:    weth = _weth;

Recommendation

Implement a zero address check using the require function and the != (inequality) operator with address(0).

Example:

// zero address check immutable contracts.
require(_projectToken != address(0), "Invalid project token address");
require(_pool != address(0), "Invalid pool address");
require(_jbxTerminal != address(0), "Invalid terminal address");
require(_weth != address(0), "Invalid weth address");

// assign after successful zero address checks.
projectToken = _projectToken;
pool = _pool;
jbxTerminal = _jbxTerminal;
_projectTokenIsZero = address(_projectToken) < address(_weth); // no change as used for bool true/false
weth = _weth;