FIAT DAO veFDT contest - Rohan16's results

Unlock liquidity for your DeFi fixed income assets.

General Information

Platform: Code4rena

Start Date: 12/08/2022

Pot Size: $35,000 USDC

Total HM: 10

Participants: 126

Period: 3 days

Judge: Justin Goro

Total Solo HM: 3

Id: 154

League: ETH

FIAT DAO

Findings Distribution

Researcher Performance

Rank: 83/126

Findings: 2

Award: $44.84

🌟 Selected for report: 0

🚀 Solo Findings: 0

1.USE OF FLOATING PRAGMA

Recommend using fixed solidity version.This is not a critical issue but this creates unsatbility to the program so having a fixed version reduces the unstability.

Instances

https://github.com/code-423n4/2022-08-fiatdao All the contracts which are in scope has the issue

//actual codes used contracts/features/Blocklist.sol:2:pragma solidity ^0.8.3; contracts/interfaces/IERC20.sol:2:pragma solidity ^0.8.3; contracts/interfaces/IBlocklist.sol:2:pragma solidity ^0.8.3; contracts/interfaces/IVotingEscrow.sol:2:pragma solidity ^0.8.3; contracts/VotingEscrow.sol:2:pragma solidity ^0.8.3;

1.USING > 0 COSTS MORE GAS THAN != 0 WHEN USED ON A UINT IN A REQUIRE() STATEMENT

INSTANCES

// Links to github file https://github.com/code-423n4/2022-08-fiatdao/blob/main/contracts/VotingEscrow.sol#L412 https://github.com/code-423n4/2022-08-fiatdao/blob/main/contracts/IVotingEscrow.sol#L448 https://github.com/code-423n4/2022-08-fiatdao/blob/main/contracts/IVotingEscrow.sol#L449 https://github.com/code-423n4/2022-08-fiatdao/blob/main/contracts/IVotingEscrow.sol#L469 https://github.com/code-423n4/2022-08-fiatdao/blob/main/contracts/IVotingEscrow.sol#L502 https://github.com/code-423n4/2022-08-fiatdao/blob/main/contracts/IVotingEscrow.sol#L529 https://github.com/code-423n4/2022-08-fiatdao/blob/main/contracts/IVotingEscrow.sol#L564 https://github.com/code-423n4/2022-08-fiatdao/blob/main/contracts/IVotingEscrow.sol#L587 https://github.com/code-423n4/2022-08-fiatdao/blob/main/contracts/IVotingEscrow.sol#L621 https://github.com/code-423n4/2022-08-fiatdao/blob/main/contracts/IVotingEscrow.sol#L635

//actual code used contracts/VotingEscrow.sol:412: require(_value > 0, "Only non zero amount"); contracts/VotingEscrow.sol:448: require(_value > 0, "Only non zero amount"); contracts/VotingEscrow.sol:449: require(locked_.amount > 0, "No lock"); contracts/VotingEscrow.sol:469: require(locked_.amount > 0, "Delegatee has no lock"); contracts/VotingEscrow.sol:502: require(locked_.amount > 0, "No lock"); contracts/VotingEscrow.sol:529: require(locked_.amount > 0, "No lock"); contracts/VotingEscrow.sol:564: require(locked_.amount > 0, "No lock"); contracts/VotingEscrow.sol:587: require(toLocked.amount > 0, "Delegatee has no lock"); contracts/VotingEscrow.sol:621: if (newLocked.amount > 0) { contracts/VotingEscrow.sol:635: require(locked_.amount > 0, "No lock");

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter