FIAT DAO veFDT contest - paribus's results

Unlock liquidity for your DeFi fixed income assets.

General Information

Platform: Code4rena

Start Date: 12/08/2022

Pot Size: $35,000 USDC

Total HM: 10

Participants: 126

Period: 3 days

Judge: Justin Goro

Total Solo HM: 3

Id: 154

League: ETH

FIAT DAO

Findings Distribution

Researcher Performance

Rank: 60/126

Findings: 2

Award: $45.06

🌟 Selected for report: 0

🚀 Solo Findings: 0

  1. Drop explicit zero initialization: https://github.com/kargakis/2022-08-fiatdao/commit/0f58bd41266fb299a19cff7477d232b10352ce33
  2. Remove lastPoint from _supplyAt, epoch_ from totalSupply , and avoid reading whole point in totalSupplyAt(redundant memory copies): https://github.com/kargakis/2022-08-fiatdao/commit/ebf5a88c09c976eb1e37670cf2679fea95e594d4
  3. _floorToWeek function body can be unchecked as it is not possible to overflow: https://github.com/kargakis/2022-08-fiatdao/commit/788e4209797f1a0e3985fcec1e921aea2ab73e87
  4. Avoid extra storage read in collectPenalty: https://github.com/kargakis/2022-08-fiatdao/commit/ee9310e473b39d6e262286db30385806cd1e9e7e
  5. token storage variable in VotingEscrow contract can be immutable: https://github.com/kargakis/2022-08-fiatdao/commit/12e34838e7df93e53edc8b83041e642696bd231d
  6. Remove redundant storage write from _checkpoint: https://github.com/kargakis/2022-08-fiatdao/commit/a88f6e7473f1fd5b619651017838c46e539d7ae4
  7. _calculatePenaltyRate function body can be unchecked as it is not possible to overflow: https://github.com/kargakis/2022-08-fiatdao/commit/bd187510d67abbf8dd54d242073b5956650f5925
  8. manager and ve storage variables can be immutable: https://github.com/kargakis/2022-08-fiatdao/commit/73e291ed604ad875f9832a547b08750112961a17
  9. Reuse local values from stack instead of accessing in memory in _checkpoint: https://github.com/kargakis/2022-08-fiatdao/commit/9c970d2e3b3c9374429a3efa0ab177e6d1d79516
  10. Calculating blockSlope in _checkpoint cannot overflow: https://github.com/kargakis/2022-08-fiatdao/commit/afb7236771d52f64d4245b5cf7ea342bbf526d80
  11. Reuse local value from stack instead of memory in increaseAmount: https://github.com/kargakis/2022-08-fiatdao/commit/8ae81a7e024b03e56cfc61f3362a4c5671e5c03a
  12. Division by 2 can be updated to bit left shift by 1: https://github.com/kargakis/2022-08-fiatdao/commit/8abdaec40f67e318a40c39ca9cd2b7de2f9dc8a6
  13. All counter increments in VotingEscrow cannot overflow: https://github.com/kargakis/2022-08-fiatdao/commit/b4a17ece9b6ca0ad1d19b19adc91e088163c48f4
  14. No math check in the binary search algorithms can overflow or underflow: https://github.com/kargakis/2022-08-fiatdao/commit/607d60e9b4e25edf0ad706d73e142e7db75e52ca

#0 - lacoop6tu

2022-08-26T15:35:24Z

Good one

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter