FIAT DAO veFDT contest - sikorico's results

QA REPORT

[QA 00] Mismatched solidity versions

The code is compiled with more than one solidity version which can cause undesired behavior.

[QA 01] Use the multiplication math operators before the divisions in the following locations

Proof of concept:

• VotingEscrow.sol#L701

[QA 02] Use safeTransfer instead transfer in the following locations

Proof of concept:

• VotingEscrow.sol#L484
• VotingEscrow.sol#L545
• VotingEscrow.sol#L656
• VotingEscrow.sol#L675
• VotingEscrow.sol#L424

[QA 03] Use two steps verification for the following contracts

Proof of concept:

• VotingEscrow.sol

[QA 04] Magic number, consider using named constant instead.

Proof of concept:

• VotingEscrow.sol#L716
• VotingEscrow.sol#L738

[QA 05] Missing event indexers

Proof of concept:

• VotingEscrow.sol#L40
• VotingEscrow.sol#L39
• VotingEscrow.sol#L41
• VotingEscrow.sol#L38

[QA 06] Not emitted event for state changes

Proof of concept:

• VotingEscrow.sol#L106
• Blocklist.sol#L14

[QA 07] Both return statement and named return

For readability purposes consider having one of the two return options (for the following functions)

Proof of concept:

• VotingEscrow.sol#L209

[QA 08] Avoid Floating pragma

Proof of concept:

• Blocklist.sol
• VotingEscrow.sol

GAS REPORT

[GAS 00] Use > 0 instead != 0 to check if an unsigned int is not 0

Proof of concept:

• VotingEscrow.sol#L447
• VotingEscrow.sol#L411

[GAS 01] Unnecessary caching of msg.sender

Proof of concept:

• VotingEscrow.sol#L899
• VotingEscrow.sol#L414
• VotingEscrow.sol#L294
• VotingEscrow.sol#L412

[GAS 02] Use custom error instead string error for the following require statements

Proof of concept:

• VotingEscrow.sol#L502
• VotingEscrow.sol#L529
• VotingEscrow.sol#L469
• VotingEscrow.sol#L501
• VotingEscrow.sol#L411