Nouns Builder contest - Noah3o6's results

A permissionless, governed protocol to deploy nouns-style DAOs complete with treasury, generative collections, and governance mechanisms.

General Information

Platform: Code4rena

Start Date: 06/09/2022

Pot Size: $90,000 USDC

Total HM: 33

Participants: 168

Period: 9 days

Judge: GalloDaSballo

Total Solo HM: 10

Id: 157

League: ETH

Nouns Builder

Findings Distribution

Researcher Performance

Rank: 124/168

Findings: 1

Award: $60.77

🌟 Selected for report: 0

🚀 Solo Findings: 0

-> EVENT IS MISSING INDEXED FIELDS Each event should use three indexed fields if there are three or more fields.

https://github.com/code-423n4/2022-09-nouns-builder/blob/main/src/auction/IAuction.sol#:~:text=event%20AuctionBid(uint256%20tokenId%2C%20address%20bidder%2C%20uint256%20amount%2C%20bool%20extended%2C%20uint256%20endTime)%3B https://github.com/code-423n4/2022-09-nouns-builder/blob/main/src/auction/IAuction.sol#:~:text=event%20AuctionSettled(uint256%20tokenId%2C%20address%20winner%2C%20uint256%20amount)%3B https://github.com/code-423n4/2022-09-nouns-builder/blob/main/src/auction/IAuction.sol#:~:text=event%20AuctionCreated(uint256%20tokenId%2C%20uint256%20startTime%2C%20uint256%20endTime)%3B https://github.com/code-423n4/2022-09-nouns-builder/blob/main/src/lib/interfaces/IERC721.sol#:~:text=event%20ApprovalForAll(address%20indexed%20owner%2C%20address%20indexed%20operator%2C%20bool%20approved)%3B https://github.com/code-423n4/2022-09-nouns-builder/blob/main/src/governance/governor/IGovernor.sol#:~:text=event%20VoteCast(address%20voter%2C%20bytes32%20proposalId%2C%20uint256%20support%2C%20uint256%20weight%2C%20string%20reason)%3B https://github.com/code-423n4/2022-09-nouns-builder/blob/main/src/lib/interfaces/IERC721.sol#:~:text=event%20ApprovalForAll(address%20indexed%20owner%2C%20address%20indexed%20operator%2C%20bool%20approved)%3B https://github.com/code-423n4/2022-09-nouns-builder/blob/main/src/lib/interfaces/IERC721Votes.sol#:~:text=event%20DelegateVotesChanged(address%20indexed%20delegate%2C%20uint256%20prevTotalVotes%2C%20uint256%20newTotalVotes)%3B

->USE A MORE RECENT VERSION OF SOLIDITY

Use a solidity version of at least 0.8.10 to have external calls skip contra

https://github.com/code-423n4/2022-09-nouns-builder/blob/main/src/lib/utils/TokenReceiver.sol#:~:text=pragma%20solidity%20%5E0.8.0%3B

#0 - GalloDaSballo

2022-09-27T00:33:09Z

R for Solidity

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter