Nouns Builder contest - fatherOfBlocks's results

Lines of code

https://github.com/code-423n4/2022-09-nouns-builder/blob/7e9fddbbacdd7d7812e912a369cfd862ee67dc03/src/governance/governor/Governor.sol#L160-L166 https://github.com/code-423n4/2022-09-nouns-builder/blob/7e9fddbbacdd7d7812e912a369cfd862ee67dc03/src/governance/governor/Governor.sol#L434-L438

Vulnerability details

Impact

When a proposal is created, the values ​​of voteStart and voteEnd are set, but when they are set, their values ​​are not validated: block.timestamp + settings.votingDelay and block.timestamp + settings.votingPeriod, be > block.timestamp. This is necessary because if the two values ​​were equal: voteStart == voteEnd would generate certain inconsistencies, for example: that the state() function returns Pending, when there is no real time to vote. In addition, there would be the problem of creating a proposal that will never be able to be voted on.

Recommended Mitigation Steps

This could be fixed by validating that voteStart has to be > voteEnd

Treasury.sol

• L141 - The execute() function has several arrays and they are used inside a for, but it is not validated that they have equal sizes so that they do not revert without displaying a correct message.

Treasury.sol

• L162 - It is not necessary to initialize a variable with its default value since it generates an extra gas cost without having benefits in the understanding of the code.

Address L50 - It is less expensive to validate "variable != 0" than "variable > 0"

Metadata Renderer

• L119/133/189/229 - It is not necessary to initialize a variable with its default value since it generates an extra gas cost without having benefits in the understanding of the code.

• L124/151/194/226/237 - It is less expensive to make ++variable or --variable, than variable + 1 for example.

Token

• L91/154 - It is less expensive to make ++variable or --variable, than variable + 1 for example.