Platform: Code4rena
Start Date: 06/09/2022
Pot Size: $90,000 USDC
Total HM: 33
Participants: 168
Period: 9 days
Judge: GalloDaSballo
Total Solo HM: 10
Id: 157
League: ETH
Rank: 71/168
Findings: 2
Award: $131.45
🌟 Selected for report: 0
🚀 Solo Findings: 0
70.6842 USDC - $70.68
proposalThresholdBps and quorumThresholdBps can be set as same value.
There are no checks like quorumThresholdBps > proposalThresholdBps .
Manual code review
Always ensure that quorumThresholdBps > proposalThresholdBps . This need to be considered while deploying and updating the values.
🌟 Selected for report: Lambda
Also found by: 0x1337, 0x1f8b, 0x4non, 0x85102, 0xA5DF, 0xNazgul, 0xSmartContract, 0xbepresent, 0xc0ffEE, 8olidity, Aymen0909, B2, Bnke0x0, CRYP70, Captainkay, CertoraInc, Ch_301, Chom, ChristianKuri, CodingNameKiki, Deivitto, Diana, DimitarDimitrov, ElKu, EthLedger, Franfran, Funen, GimelSec, JansenC, Jeiwan, Jujic, Lead_Belly, MEP, MasterCookie, MiloTruck, Noah3o6, PPrieditis, PaludoX0, Picodes, PwnPatrol, R2, Randyyy, RaymondFam, Respx, ReyAdmirado, Rolezn, Samatak, Tointer, Tomo, V_B, Waze, _Adam, __141345__, a12jmx, ak1, asutorufos, azephiar, ballx, bharg4v, bin2chen, bobirichman, brgltd, bulej93, c3phas, cccz, ch0bu, cloudjunky, cryptonue, cryptostellar5, cryptphi, csanuragjain, d3e4, datapunk, davidbrai, delfin454000, dharma09, dic0de, dipp, djxploit, eierina, erictee, fatherOfBlocks, gogo, hansfriese, hyh, imare, indijanc, izhuer, jonatascm, ladboy233, leosathya, lucacez, lukris02, m9800, martin, minhtrng, ne0n, neumo, oyc_109, p_crypt0, pashov, pauliax, pcarranzav, pedr02b2, peritoflores, pfapostol, rbserver, ret2basic, robee, rvierdiiev, sach1r0, sahar, scaraven, sikorico, simon135, slowmoses, sorrynotsorry, tnevler, tonisives, volky, yixxas, zkhorse, zzzitron
60.7743 USDC - $60.77
This will favor the owner. It would be a decentralization issue..
When initializing the Auction.sol, the minBidIncrement is 10
At times, owner can set this to zero or to high like whatever the value they wants.
I believe this can be attributed with decentralization issue.
Manual code review.
Set minimum and maximum cap for minBidIncrement. Owner can not change lesser or higher than this value.
#0 - GalloDaSballo
2022-09-26T17:07:59Z
Owner in this case is Governance, meaning previous holders. This may be used to "cartelize" but that would happen at the detriment of the project, and within governance rules.
I think Low Severity is more appropriate
#1 - GalloDaSballo
2022-09-26T17:08:07Z
L