Platform: Code4rena
Start Date: 06/09/2022
Pot Size: $90,000 USDC
Total HM: 33
Participants: 168
Period: 9 days
Judge: GalloDaSballo
Total Solo HM: 10
Id: 157
League: ETH
Rank: 133/168
Findings: 1
Award: $60.77
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: Lambda
Also found by: 0x1337, 0x1f8b, 0x4non, 0x85102, 0xA5DF, 0xNazgul, 0xSmartContract, 0xbepresent, 0xc0ffEE, 8olidity, Aymen0909, B2, Bnke0x0, CRYP70, Captainkay, CertoraInc, Ch_301, Chom, ChristianKuri, CodingNameKiki, Deivitto, Diana, DimitarDimitrov, ElKu, EthLedger, Franfran, Funen, GimelSec, JansenC, Jeiwan, Jujic, Lead_Belly, MEP, MasterCookie, MiloTruck, Noah3o6, PPrieditis, PaludoX0, Picodes, PwnPatrol, R2, Randyyy, RaymondFam, Respx, ReyAdmirado, Rolezn, Samatak, Tointer, Tomo, V_B, Waze, _Adam, __141345__, a12jmx, ak1, asutorufos, azephiar, ballx, bharg4v, bin2chen, bobirichman, brgltd, bulej93, c3phas, cccz, ch0bu, cloudjunky, cryptonue, cryptostellar5, cryptphi, csanuragjain, d3e4, datapunk, davidbrai, delfin454000, dharma09, dic0de, dipp, djxploit, eierina, erictee, fatherOfBlocks, gogo, hansfriese, hyh, imare, indijanc, izhuer, jonatascm, ladboy233, leosathya, lucacez, lukris02, m9800, martin, minhtrng, ne0n, neumo, oyc_109, p_crypt0, pashov, pauliax, pcarranzav, pedr02b2, peritoflores, pfapostol, rbserver, ret2basic, robee, rvierdiiev, sach1r0, sahar, scaraven, sikorico, simon135, slowmoses, sorrynotsorry, tnevler, tonisives, volky, yixxas, zkhorse, zzzitron
60.7742 USDC - $60.77
@return tags are missing in all functions (where it is needed) in all contracts.
ERC1967Upgrade._upgradeToAndCall (@param tag for _forceCall is missing)
ERC1967Upgrade._upgradeToAndCallUUPS (@param tag for _forceCall is missing)
Address.sol (all functions have no @param tags)
constructor (NatSpec is missing)
ERC721.safeTransferFrom (@param tag for _data is missing)
MetadataRenderer._generateSeed (@param tag for _tokenId is missing)
MetadataRenderer._getItemImage (@param tags are missing)
MetadataRenderer._encodeAsJson (@param tag is missing)
@param tags are missing in all events in files: IGovernor.sol, ITreasury.sol,IERC721Votes.sol, IInitializable.sol, IPropertyIPFSMetadataRenderer.sol
NatSpec is incomplete: IWETH.sol, SafeCast.sol, TokenReceiver.sol, etadataRendererTypesV1.sol
Context:
Description:
Public functions can be declared external if they are not called by the contract.
Recommendation:
Declare these functions as external instead of public.
#0 - GalloDaSballo
2022-09-27T01:08:02Z
NC
R
1R 1NC