Nouns Builder contest - sikorico's results

QA REPORT

[LOW] Not verified input

At the following functions you should verify the parameters that are being assigned to a state variable.

Proof of concept:

• Manager.sol#L61
• Auction.sol#L39

[LOW] The project is compiled with different solidity versions

[LOW] Missing pause functionality

Example: MetadataRenderer.sol

[LOW] Missing nonReentrancy modifier

The following functions allows attackers to try reentrancy since they are calling to external contracts / transferring eth. Consider adding a nonReentrancy modifier.

Proof of concept:

• Gov.t.sol#L170
• Gov.t.sol#L596

[LOW] Consider adding two steps verification process

Protocol ownership transfer should be dealt with great care. Adding two steps verification is necessary for that matter.

Proof of concept:

• Manager.t.sol
• NounsBuilderTest.sol

[NON CRITICAL] Missing function spec comments

Proof of concept:

• Auction.sol#L282
• Treasury.sol#L68

[NON CRITICAL] Unused function parameters should have name removed

If for any reason the following unused parameters are necessary then remove their naming (since only the type matters for function signature)

Example: Manager.sol#L209

[NON CRITICAL] Consider emitting an event at the following functions

Proof of concept:

• NounsBuilderTest.sol#L42
• Token.sol#L30

GAS REPORT

[GAS 00] transferFrom(address(this), to, amount) can be changed to transfer(to, amount) to save gas

Proof of concept:

• Gov.t.sol#L814
• Gov.t.sol#L778
• Auction.sol#L191

[GAS 01] abiEncodePacked() instead abiEncode() in the following locations

Proof of concept:

• Gov.t.sol#L417
• Gov.t.sol#L328
• Governor.sol#L103
• Manager.sol#L67
• Gov.t.sol#L394

--